[payment] Code generation: update services and models#1714
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several payment model files to improve the handling of unknown enum values during serialization and deserialization, ensuring raw values are preserved when a predefined match is missing. Across all modified models, a potential NullReferenceException was identified where .Value is accessed on nullable enum types without a null check. It is recommended to use the null-conditional operator to safely handle these optional fields and prevent runtime crashes.
| return "moreThan60Days"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
The change from return null; to return value.Value; introduces a potential NullReferenceException when the input value is null. Since this field is optional in the model, it can be null during serialization. Using the null-conditional operator ensures that null is returned safely if the enum instance is missing, while still allowing the raw value to be serialized for unknown enum members.
return value?.Value;| return "moreThan60Days"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "debit"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "moreThan60Days"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "moreThan60Days"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "other"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "Error"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "CompanyName"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "Success"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;| return "VAT"; | ||
|
|
||
| return null; | ||
| return value.Value; |
There was a problem hiding this comment.
Potential NullReferenceException if value is null. Use the null-conditional operator to safely handle optional fields during serialization.
return value?.Value;
2 participants
This PR contains the automated changes for the
paymentservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.