Merge pull request #1520 from Adyen/nullable-attributes

Make non-native attributes nullable

Author: gcatanese

src/__tests__/terminalCloudAPI.spec.ts

@@ -452,5 +452,5 @@ export const syncTerminalPaymentResponse = {
       "additionalAttribute": "somethingElse",
     }
   }
-}
+};
 

src/__tests__/terminalSettings.spec.ts

@@ -7,20 +7,17 @@ describe("TerminalSettings properties", () => {
     terminalSettings = new TerminalSettings();
   });
 
-  // TMP: commented out to decide if attributes should be nullable (even when OpenAPI spec does not allow it)
-  // https://github.com/Adyen/adyen-node-api-library/issues/1351
-  //
-  // test("should allow properties to be null", () => {
-  //   terminalSettings.cardholderReceipt = null;
-  //   terminalSettings.connectivity = null;
-  //   terminalSettings.gratuities = null;
-  //   terminalSettings.hardware = null;
-
-  //   expect(terminalSettings.cardholderReceipt).toBeNull();
-  //   expect(terminalSettings.connectivity).toBeNull();
-  //   expect(terminalSettings.gratuities).toBeNull();
-  //   expect(terminalSettings.hardware).toBeNull();
-  // });
+  test("should allow properties to be null", () => {
+    terminalSettings.cardholderReceipt = null;
+    terminalSettings.connectivity = null;
+    terminalSettings.gratuities = null;
+    terminalSettings.hardware = null;
+
+    expect(terminalSettings.cardholderReceipt).toBeNull();
+    expect(terminalSettings.connectivity).toBeNull();
+    expect(terminalSettings.gratuities).toBeNull();
+    expect(terminalSettings.hardware).toBeNull();
+  });
 
   test("should allow properties to be undefined", () => {
     terminalSettings.cardholderReceipt = undefined;

src/__tests__/webhooks/transferWebhook.spec.ts

@@ -2,8 +2,7 @@ import { EstimationTrackingData } from "../../typings/transferWebhooks/estimatio
 import { TransferWebhooksHandler } from "../../typings/transferWebhooks/transferWebhooksHandler";
 
 describe("Transfer Webhook Serialization", (): void => {
-  // disabling temporarily (must address oneOf deserialization issue)
-  it.skip("should correctly deserialize union types in transfer webhooks", () => {
+  test("should correctly deserialize union types in transfer webhooks", () => {
     // Simplest possible webhook with just the fields we need to test
     const webhookData = {
       data: {

src/typings/acsWebhooks/authenticationInfo.ts

@@ -15,7 +15,7 @@ export class AuthenticationInfo {
     * Universally unique transaction identifier assigned by the Access Control Server (ACS) to identify a single transaction.
     */
     "acsTransId": string;
-    "challenge"?: ChallengeInfo;
+    "challenge"?: ChallengeInfo | null;
     /**
     * Specifies a preference for receiving a challenge. Possible values:  * **01**: No preference * **02**: No challenge requested * **03**: Challenge requested (preference) * **04**: Challenge requested (mandate) * **05**: No challenge requested (transactional risk analysis is already performed) * **07**: No challenge requested (SCA is already performed) * **08**: No challenge requested (trusted beneficiaries exemption of no challenge required) * **09**: Challenge requested (trusted beneficiaries prompt requested if challenge required) * **80**: No challenge requested (secure corporate payment with Mastercard) * **82**: No challenge requested (secure corporate payment with Visa) 
     */
@@ -83,7 +83,7 @@ export class AuthenticationInfo {
         {
             "name": "challenge",
             "baseName": "challenge",
-            "type": "ChallengeInfo",
+            "type": "ChallengeInfo | null",
             "format": ""
         },
         {

src/typings/binLookup/costEstimateRequest.ts

@@ -15,7 +15,7 @@ import { Recurring } from "./recurring";
 
 export class CostEstimateRequest {
     "amount": Amount;
-    "assumptions"?: CostEstimateAssumptions;
+    "assumptions"?: CostEstimateAssumptions | null;
     /**
     * The card number (4-19 characters) for PCI compliant use cases. Do not use any separators.  > Either the `cardNumber` or `encryptedCardNumber` field must be provided in a payment request.
     */
@@ -28,8 +28,8 @@ export class CostEstimateRequest {
     * The merchant account identifier you want to process the (transaction) request with.
     */
     "merchantAccount": string;
-    "merchantDetails"?: MerchantDetails;
-    "recurring"?: Recurring;
+    "merchantDetails"?: MerchantDetails | null;
+    "recurring"?: Recurring | null;
     /**
     * The `recurringDetailReference` you want to use for this cost estimate. The value `LATEST` can be used to select the most recently stored recurring detail.
     */
@@ -57,7 +57,7 @@ export class CostEstimateRequest {
         {
             "name": "assumptions",
             "baseName": "assumptions",
-            "type": "CostEstimateAssumptions",
+            "type": "CostEstimateAssumptions | null",
             "format": ""
         },
         {
@@ -81,13 +81,13 @@ export class CostEstimateRequest {
         {
             "name": "merchantDetails",
             "baseName": "merchantDetails",
-            "type": "MerchantDetails",
+            "type": "MerchantDetails | null",
             "format": ""
         },
         {
             "name": "recurring",
             "baseName": "recurring",
-            "type": "Recurring",
+            "type": "Recurring | null",
             "format": ""
         },
         {

src/typings/binLookup/costEstimateResponse.ts

@@ -12,8 +12,8 @@ import { CardBin } from "./cardBin";
 
 
 export class CostEstimateResponse {
-    "cardBin"?: CardBin;
-    "costEstimateAmount"?: Amount;
+    "cardBin"?: CardBin | null;
+    "costEstimateAmount"?: Amount | null;
     /**
     * Adyen\'s 16-character reference associated with the request.
     */
@@ -31,13 +31,13 @@ export class CostEstimateResponse {
         {
             "name": "cardBin",
             "baseName": "cardBin",
-            "type": "CardBin",
+            "type": "CardBin | null",
             "format": ""
         },
         {
             "name": "costEstimateAmount",
             "baseName": "costEstimateAmount",
-            "type": "Amount",
+            "type": "Amount | null",
             "format": ""
         },
         {

src/typings/binLookup/threeDSAvailabilityResponse.ts

@@ -13,7 +13,7 @@ import { ThreeDS2CardRangeDetail } from "./threeDS2CardRangeDetail";
 
 
 export class ThreeDSAvailabilityResponse {
-    "binDetails"?: BinDetail;
+    "binDetails"?: BinDetail | null;
     /**
     * List of Directory Server (DS) public keys.
     */
@@ -39,7 +39,7 @@ export class ThreeDSAvailabilityResponse {
         {
             "name": "binDetails",
             "baseName": "binDetails",
-            "type": "BinDetail",
+            "type": "BinDetail | null",
             "format": ""
         },
         {

src/typings/checkout/additionalDataSubMerchant.ts

@@ -34,7 +34,7 @@ export class AdditionalDataSubMerchant {
     */
     "subMerchant_subSeller_subSellerNr_mcc"?: string;
     /**
-    * Required for transactions performed by registered payment facilitators. The name of the sub-merchant. Based on scheme specifications, this value will overwrite the shopper statement  that will appear in the card statement. * Format: Alphanumeric * Maximum length: 22 characters
+    * Required for transactions performed by registered payment facilitators. The name of the sub-merchant. Based on scheme specifications, this value will overwrite the shopper statement  that will appear in the card statement. Exception: for acquirers in Brazil, this value does not overwrite the shopper statement. * Format: Alphanumeric * Maximum length: 22 characters
     */
     "subMerchant_subSeller_subSellerNr_name"?: string;
     /**

src/typings/checkout/airline.ts

@@ -15,7 +15,7 @@ import { TravelAgency } from "./travelAgency";
 
 
 export class Airline {
-    "agency"?: Agency;
+    "agency"?: Agency | null;
     /**
     * The amount charged for boarding the plane, in [minor units](https://docs.adyen.com/development-resources/currency-codes). * Encoding: Numeric * minLength: 1 character * maxLength: 11 characters
     */
@@ -50,8 +50,8 @@ export class Airline {
     */
     "passengerName": string;
     "passengers"?: Array<Passenger>;
-    "ticket"?: Ticket;
-    "travelAgency"?: TravelAgency;
+    "ticket"?: Ticket | null;
+    "travelAgency"?: TravelAgency | null;
 
     static readonly discriminator: string | undefined = undefined;
 
@@ -61,7 +61,7 @@ export class Airline {
         {
             "name": "agency",
             "baseName": "agency",
-            "type": "Agency",
+            "type": "Agency | null",
             "format": ""
         },
         {
@@ -127,13 +127,13 @@ export class Airline {
         {
             "name": "ticket",
             "baseName": "ticket",
-            "type": "Ticket",
+            "type": "Ticket | null",
             "format": ""
         },
         {
             "name": "travelAgency",
             "baseName": "travelAgency",
-            "type": "TravelAgency",
+            "type": "TravelAgency | null",
             "format": ""
         }    ];
 

src/typings/checkout/applicationInfo.ts

@@ -14,12 +14,12 @@ import { ShopperInteractionDevice } from "./shopperInteractionDevice";
 
 
 export class ApplicationInfo {
-    "adyenLibrary"?: CommonField;
-    "adyenPaymentSource"?: CommonField;
-    "externalPlatform"?: ExternalPlatform;
-    "merchantApplication"?: CommonField;
-    "merchantDevice"?: MerchantDevice;
-    "shopperInteractionDevice"?: ShopperInteractionDevice;
+    "adyenLibrary"?: CommonField | null;
+    "adyenPaymentSource"?: CommonField | null;
+    "externalPlatform"?: ExternalPlatform | null;
+    "merchantApplication"?: CommonField | null;
+    "merchantDevice"?: MerchantDevice | null;
+    "shopperInteractionDevice"?: ShopperInteractionDevice | null;
 
     static readonly discriminator: string | undefined = undefined;
 
@@ -29,37 +29,37 @@ export class ApplicationInfo {
         {
             "name": "adyenLibrary",
             "baseName": "adyenLibrary",
-            "type": "CommonField",
+            "type": "CommonField | null",
             "format": ""
         },
         {
             "name": "adyenPaymentSource",
             "baseName": "adyenPaymentSource",
-            "type": "CommonField",
+            "type": "CommonField | null",
             "format": ""
         },
         {
             "name": "externalPlatform",
             "baseName": "externalPlatform",
-            "type": "ExternalPlatform",
+            "type": "ExternalPlatform | null",
             "format": ""
         },
         {
             "name": "merchantApplication",
             "baseName": "merchantApplication",
-            "type": "CommonField",
+            "type": "CommonField | null",
             "format": ""
         },
         {
             "name": "merchantDevice",
             "baseName": "merchantDevice",
-            "type": "MerchantDevice",
+            "type": "MerchantDevice | null",
             "format": ""
         },
         {
             "name": "shopperInteractionDevice",
             "baseName": "shopperInteractionDevice",
-            "type": "ShopperInteractionDevice",
+            "type": "ShopperInteractionDevice | null",
             "format": ""
         }    ];