Skip to content

Use LibraryConstants values in unit tests #1498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 2 commits into from
May 13, 2025
+8 −6
Merged

Use LibraryConstants values in unit tests #1498

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a85b49
Use LibraryConstants values in unit tests
gcatanese May 13, 2025
24c7a23
Use template literals instead of str concatenation
gcatanese May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/__tests__/httpClient.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import { binlookup } from "../typings";
import { ApiConstants } from "../constants/apiConstants";
import {paymentMethodsSuccess} from "../__mocks__/checkout/paymentMethodsSuccess";
import Config from "../config";
import LibraryConstants from "../constants/libraryConstants";


beforeEach((): void => {
nock.cleanAll();
Expand Down Expand Up @@ -108,9 +110,9 @@ describe("HTTP Client", function (): void {
const client = createClient();
const checkout = new CheckoutAPI(client);

const expectedUserAgent = `adyen-node-api-library/26.1.0`;
const expectedLibraryName = `adyen-node-api-library`;
const expectedLibraryVersion = `26.1.0`;
const expectedUserAgent = `${LibraryConstants.LIB_NAME}/${LibraryConstants.LIB_VERSION}`;
const expectedLibraryName = LibraryConstants.LIB_NAME;
const expectedLibraryVersion = LibraryConstants.LIB_VERSION;

const scope = nock("https://checkout-test.adyen.com/v71", {
reqheaders: {
Expand Down Expand Up @@ -145,9 +147,9 @@ describe("HTTP Client", function (): void {
client.config.applicationName = "testApp";
const checkout = new CheckoutAPI(client);

const expectedUserAgent = `testApp adyen-node-api-library/26.1.0`; // include applicationName too
const expectedLibraryName = `adyen-node-api-library`;
const expectedLibraryVersion = `26.1.0`;
const expectedUserAgent = `testApp ${LibraryConstants.LIB_NAME}/${LibraryConstants.LIB_VERSION}`; // include applicationName too
const expectedLibraryName = LibraryConstants.LIB_NAME;
const expectedLibraryVersion = LibraryConstants.LIB_VERSION;

const scope = nock("https://checkout-test.adyen.com/v71", {
reqheaders: {
Expand Down