[payout] Code generation: update services and models#1611
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request contains automated code generation updates for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, generated automatically, updates services and models for the payout service. The changes are mostly minor documentation updates. However, a new property sepadirectdebit_sepadirectdebit_dueDate has been introduced in ResponseAdditionalDataSepa with a redundant name. I've suggested corrections to improve consistency and readability, which also includes fixing a typo in the associated comment. These changes might need to be propagated back to the OpenAPI specification to prevent them from being overwritten in future generations.
| /** | ||
| * The date that the the shopper\'s bank account is charged. | ||
| */ | ||
| "sepadirectdebit_sepadirectdebit_dueDate"?: string; |
There was a problem hiding this comment.
The property name sepadirectdebit_sepadirectdebit_dueDate appears to have a redundant sepadirectdebit_ prefix. For consistency with other properties in this class (e.g., sepadirectdebit_mandateId), it should likely be sepadirectdebit_dueDate.
Additionally, the comment contains a typo ('the the') and an unnecessary backslash.
While this might originate from an auto-generation process, correcting it here improves code clarity and maintainability.
| /** | |
| * The date that the the shopper\'s bank account is charged. | |
| */ | |
| "sepadirectdebit_sepadirectdebit_dueDate"?: string; | |
| /** | |
| * The date that the shopper's bank account is charged. | |
| */ | |
| "sepadirectdebit_dueDate"?: string; |
| { | ||
| "name": "sepadirectdebit_sepadirectdebit_dueDate", | ||
| "baseName": "sepadirectdebit.sepadirectdebit.dueDate", | ||
| "type": "string", | ||
| "format": "" | ||
| }, |
There was a problem hiding this comment.
To align with the suggested property name change, the name and baseName in this attributeTypeMap entry should be updated to remove the redundant sepadirectdebit segment.
| { | |
| "name": "sepadirectdebit_sepadirectdebit_dueDate", | |
| "baseName": "sepadirectdebit.sepadirectdebit.dueDate", | |
| "type": "string", | |
| "format": "" | |
| }, | |
| { | |
| "name": "sepadirectdebit_dueDate", | |
| "baseName": "sepadirectdebit.dueDate", | |
| "type": "string", | |
| "format": "" | |
| }, |
25ca52b to
457a7d2
Compare
457a7d2 to
f74cbc9
Compare
This PR contains the automated changes for the
payoutservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.Payout API
ResponseAdditionalDataSepaadd attributesepadirectdebit_sepadirectdebit_dueDate