Skip to content

[payout] Code generation: update services and models #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gcatanese merged 1 commit into from
Jan 16, 2026
Merged

[payout] Code generation: update services and models #1611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/typings/payout/amount.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@

export class Amount {
/**
* The three-character [ISO currency code](https://docs.adyen.com/development-resources/currency-codes#currency-codes).
* The three-character [ISO currency code](https://docs.adyen.com/development-resources/currency-codes#currency-codes) of the amount.
*/
"currency": string;
/**
* The amount of the transaction, in [minor units](https://docs.adyen.com/development-resources/currency-codes#minor-units).
* The numeric value of the amount, in [minor units](https://docs.adyen.com/development-resources/currency-codes#minor-units).
*/
"value": number;

Expand Down
10 changes: 10 additions & 0 deletions src/typings/payout/responseAdditionalDataSepa.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ export class ResponseAdditionalDataSepa {
*/
"sepadirectdebit_mandateId"?: string;
/**
* The date that the the shopper\'s bank account is charged.
*/
"sepadirectdebit_sepadirectdebit_dueDate"?: string;
Comment on lines 20 to +23

@gemini-code-assist gemini-code-assist Bot Jan 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The property name sepadirectdebit_sepadirectdebit_dueDate appears to have a redundant sepadirectdebit_ prefix. For consistency with other properties in this class (e.g., sepadirectdebit_mandateId), it should likely be sepadirectdebit_dueDate.

Additionally, the comment contains a typo ('the the') and an unnecessary backslash.

While this might originate from an auto-generation process, correcting it here improves code clarity and maintainability.

Suggested change
/**
* The date that the the shopper\'s bank account is charged.
*/
"sepadirectdebit_sepadirectdebit_dueDate"?: string;
/**
* The date that the shopper's bank account is charged.
*/
"sepadirectdebit_dueDate"?: string;

/**
* This field can take one of the following values: * OneOff: (OOFF) Direct debit instruction to initiate exactly one direct debit transaction. * First: (FRST) Initial/first collection in a series of direct debit instructions. * Recurring: (RCUR) Direct debit instruction to carry out regular direct debit transactions initiated by the creditor. * Final: (FNAL) Last/final collection in a series of direct debit instructions. Example: OOFF
*/
"sepadirectdebit_sequenceType"?: string;
Expand All @@ -39,6 +43,12 @@ export class ResponseAdditionalDataSepa {
"type": "string",
"format": ""
},
{
"name": "sepadirectdebit_sepadirectdebit_dueDate",
"baseName": "sepadirectdebit.sepadirectdebit.dueDate",
"type": "string",
"format": ""
},
Comment on lines +46 to +51

@gemini-code-assist gemini-code-assist Bot Jan 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To align with the suggested property name change, the name and baseName in this attributeTypeMap entry should be updated to remove the redundant sepadirectdebit segment.

Suggested change
{
"name": "sepadirectdebit_sepadirectdebit_dueDate",
"baseName": "sepadirectdebit.sepadirectdebit.dueDate",
"type": "string",
"format": ""
},
{
"name": "sepadirectdebit_dueDate",
"baseName": "sepadirectdebit.dueDate",
"type": "string",
"format": ""
},

{
"name": "sepadirectdebit_sequenceType",
"baseName": "sepadirectdebit.sequenceType",
Expand Down