feat: export NexoCrypto from package index#1710
Closed
gourabsingha1 wants to merge 3 commits into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request exports the NexoCrypto class from src/index.ts to support local terminal API security. The reviewer suggests also exporting InvalidSecurityKeyException alongside NexoCrypto to facilitate proper error handling and prevent deep imports for library consumers.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #1447 by exporting the
NexoCryptoclass from the main library entry point (src/index.ts).Previously,
NexoCryptowas not exported from the main entry point, forcing developers to import it via deep internal paths like@adyen/api-library/lib/src/security/nexoCrypto. Since the library compiles to CommonJS, this deep path resolution under ESM-based runtimes returned the default wrapper object{ default: [class NexoCrypto] }instead of the class constructor itself, causing runtimeTypeError: NexoCrypto is not a constructorunless developers manually appended.default.By exporting it as a named export from the main index file, both ESM and CommonJS developers can cleanly import
NexoCryptodirectly from the package root:import { NexoCrypto } from '@adyen/api-library';Approach
Added
export { default as NexoCrypto } from "./security/nexoCrypto";tosrc/index.ts.Testing
npm run build.npm test) and verified that all 532 tests pass.