optimize-contructor:

[hieuhidro]

• Remove $session->getQuote from constructor
• Load the quote when it is needed.

---

name: PR Template

Description

• Enhancement: Remove $session->getQuote() from constructor, load the quote when it is needed. Load the quote from constructor is a bad practice, if the session hasn't loaded the quote from database, this line will load the quote from database, it increase the create object time.
• This line bypass the function loadCustomerQuote (\Magento\Checkout\Observer\LoadCustomerQuoteObserver)

How To Reproduce

Steps to reproduce the behavior:

1. Go to 'domain.com/checkout/'
2. Login as a customer
3. Affirm constructor by passing the function loadCustomerQuote

Expected behavior

• Affirm loads the quote after $checkoutSession->loadCustomerQuote()

Screenshots

Benefits

• Improve performance and fix the issue load wrong customer quote.

Additional information

[sunilit42]

• I m getting speed issue from popup close to redirect on success page
• there is no loader, when it is redirect to page, so customer is confuse is doing something or not

can we do something?

[hieuhidro]

• I m getting speed issue from popup close to redirect on success page
• there is no loader, when it is redirect to page, so customer is confuse is doing something or not

can we do something?

You means my update affects those features?

[sunilit42]

I did not test with your changes
I did not see any link to create issue, so i added comment here
sorry about that