Skip to content

Add support for CREATE USER VALID UNTIL clause#264

Merged
git-hulk merged 2 commits intoAfterShip:masterfrom
git-hulk:add-valid-until-clause
Apr 16, 2026
Merged

Add support for CREATE USER VALID UNTIL clause#264
git-hulk merged 2 commits intoAfterShip:masterfrom
git-hulk:add-valid-until-clause

Conversation

@git-hulk
Copy link
Copy Markdown
Member

Summary

  • Add parsing support for the VALID UNTIL clause in CREATE USER statements (closes Add support for CREATE USER VALID UNTIL #263)
  • Add VALID and UNTIL keywords, ValidUntil AST field, parser logic, formatter output, and tree walk support
  • Add test cases: standalone VALID UNTIL, combined with IDENTIFIED, infinity value, and multi-clause statements

Test plan

  • All existing tests pass (go test ./...)
  • Verified the exact example from Add support for CREATE USER VALID UNTIL #263: CREATE USER test VALID UNTIL '2026-12-12 00:00:00'
  • Format and beautify output verified for all new test cases

🤖 Generated with Claude Code

Closes AfterShip#263

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@git-hulk git-hulk requested a review from Lance726 April 16, 2026 04:13
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 620c176a47

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread parser/ast.go
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@git-hulk git-hulk merged commit d5e88a6 into AfterShip:master Apr 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for CREATE USER VALID UNTIL

2 participants