resolve comments

Author: Agent-Hellboy

Lib/configparser.py

@@ -753,12 +753,12 @@ def read(self, filenames, encoding=None):
             try:
                 with open(filename, encoding=encoding) as fp:
                     self._read(fp, filename)
-                    self._loaded_sources.append(filename)
             except OSError:
                 continue
             if isinstance(filename, os.PathLike):
                 filename = os.fspath(filename)
             read_ok.append(filename)
+        self._loaded_sources.extend(read_ok)
         return read_ok
 
     def read_file(self, f, source=None):
@@ -781,7 +781,6 @@ def read_string(self, string, source='<string>'):
         """Read configuration from a given string."""
         sfile = io.StringIO(string)
         self.read_file(sfile, source)
-        self._loaded_sources.append(source)
 
     def read_dict(self, dictionary, source='<dict>'):
         """Read configuration from a dictionary.

Lib/test/test_configparser.py

@@ -980,7 +980,7 @@ def test_set_nonstring_types(self):
         self.assertRaises(TypeError, cf.set, "sect", 123, "invalid opt name!")
         self.assertRaises(TypeError, cf.add_section, 123)
 
-    def test_str_and_repr(self):
+    def test_str(self):
         self.maxDiff = None
         cf = self.config_class(allow_no_value=True, delimiters=('=',), strict=True)
         cf.add_section("sect1")
@@ -998,14 +998,27 @@ def test_str_and_repr(self):
         )
         self.assertEqual(str(cf), expected_str)
 
+    def test_repr(self):
+        self.maxDiff = None
+        cf = self.config_class(allow_no_value=True, delimiters=('=',), strict=True)
+        cf.add_section("sect1")
+        cf.add_section("sect2")
+        cf.add_section("sect3")
+        cf.add_section("sect4")
+        cf.add_section("sect5")
+        cf.add_section("sect6")
+        cf.set("sect1", "option1", "foo")
+        cf.set("sect2", "option2", "bar")
+        cf.read_string("")
+
         dict_type = type(cf._dict).__name__
 
         expected_repr = (
             f"<{cf.__class__.__name__}("
             f"params={{'dict_type': '{dict_type}', 'allow_no_value': True, "
             "'delimiters': ('=',), 'strict': True, 'default_section': 'DEFAULT', "
             "'interpolation': 'BasicInterpolation'}, "
-            "state={'loaded_sources': [], 'sections_count': 6, "
+            "state={'loaded_sources': ['<string>'], 'sections_count': 6, "
             "'sections': ['sect1', 'sect2', 'sect3', 'sect4', 'sect5'], "
             "'sections_truncated': '...and 1 more'})>"
         )

Misc/ACKS

@@ -1598,8 +1598,8 @@ Joel Rosdahl
 Erik Rose
 Mark Roseman
 Josh Rosenberg
-Jim Roskind
 Prince Roshan
+Jim Roskind
 Brian Rosner
 Ignacio Rossi
 Guido van Rossum