Isolate script test runner files

Author: AbrahamGreenman

scripts/release/gh-release.test.ts

@@ -9,6 +9,7 @@ import { promisify } from "node:util";
 const execFileAsync = promisify(execFile);
 const repoRoot = process.cwd();
 const scriptPath = path.join(repoRoot, "scripts", "release", "gh-release.sh");
+const FIXTURE_RELEASE_HELPER_TIMEOUT_MS = 15_000;
 
 function escapeRegExp(value: string): string {
   return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
@@ -208,7 +209,7 @@ async function runFixtureReleaseHelper(fixture: {
         RAY_TEST_LOG: fixture.logPath,
       },
       maxBuffer: 64 * 1024,
-      timeout: 5_000,
+      timeout: FIXTURE_RELEASE_HELPER_TIMEOUT_MS,
     });
 
     return { code: 0, stderr, stdout };
@@ -222,6 +223,27 @@ async function runFixtureReleaseHelper(fixture: {
   }
 }
 
+async function assertFixtureReleaseHelperSucceeded(
+  fixture: { logPath: string },
+  result: { code: number; stderr: string; stdout: string },
+): Promise<void> {
+  const commandLog = await readFile(fixture.logPath, "utf8").catch(() => "");
+
+  assert.equal(
+    result.code,
+    0,
+    [
+      "expected release helper fixture to exit 0",
+      "stdout:",
+      result.stdout,
+      "stderr:",
+      result.stderr,
+      "commands:",
+      commandLog,
+    ].join("\n"),
+  );
+}
+
 test("gh release helper validates syntax and dry-runs without mutating git state", async () => {
   const version = await readCurrentVersion();
   const escapedVersion = escapeRegExp(version);
@@ -323,7 +345,7 @@ test("gh release helper continues when GitHub reports releases are missing", asy
 
   const result = await runFixtureReleaseHelper(fixture);
 
-  assert.equal(result.code, 0);
+  await assertFixtureReleaseHelperSucceeded(fixture, result);
   assert.match(
     result.stdout,
     /Done\. Actions publish to npm when each release is in published state\./,
@@ -352,7 +374,7 @@ test("gh release helper reuses matching local annotated tags", async (t) => {
 
   const result = await runFixtureReleaseHelper(fixture);
 
-  assert.equal(result.code, 0);
+  await assertFixtureReleaseHelperSucceeded(fixture, result);
   assert.match(result.stdout, /Reusing local annotated tag core-v1\.2\.3/);
   assert.match(result.stdout, /Reusing local annotated tag sdk-v1\.2\.3/);
 
@@ -378,7 +400,7 @@ test("gh release helper resumes after remote tags or releases already exist safe
 
   const result = await runFixtureReleaseHelper(fixture);
 
-  assert.equal(result.code, 0);
+  await assertFixtureReleaseHelperSucceeded(fixture, result);
   assert.match(result.stdout, /Reusing remote annotated tag core-v1\.2\.3/);
   assert.match(result.stdout, /Reusing remote annotated tag sdk-v1\.2\.3/);
   assert.match(result.stdout, /Reusing GitHub release core-v1\.2\.3/);

scripts/test-runner.test.ts

@@ -158,6 +158,7 @@ test("runTestCli dispatches bounded built tests before script tests", async (t)
   await mkdir(path.join(tempDir, "scripts"), { recursive: true });
   await writeFile(path.join(tempDir, "apps", "gateway", "dist", "index.test.js"), "");
   await writeFile(path.join(tempDir, "scripts", "package-runtime-coverage.test.ts"), "");
+  await writeFile(path.join(tempDir, "scripts", "validate-configs.test.ts"), "");
 
   const commands: Array<{ binary: string; args: string[]; cwd?: string; timeoutMs?: number }> = [];
   const code = await runTestCli({
@@ -179,7 +180,7 @@ test("runTestCli dispatches bounded built tests before script tests", async (t)
   });
 
   assert.equal(code, 0);
-  assert.equal(commands.length, 2);
+  assert.equal(commands.length, 3);
   assert.equal(commands[0]?.binary, "/usr/local/bin/node");
   assert.deepEqual(commands[0]?.args.slice(0, 2), ["--test", "--test-concurrency=1"]);
   assert.equal(
@@ -200,6 +201,16 @@ test("runTestCli dispatches bounded built tests before script tests", async (t)
   );
   assert.equal(commands[1]?.cwd, tempDir);
   assert.equal(commands[1]?.timeoutMs, 123_456);
+  assert.equal(commands[2]?.binary, "/usr/local/bin/bun");
+  assert.deepEqual(commands[2]?.args.slice(0, 3), [
+    "test",
+    "--max-concurrency=1",
+    "--timeout=120000",
+  ]);
+  assert.equal(commands[2]?.args.length, 4);
+  assert.equal(commands[2]?.args.at(-1), path.join(tempDir, "scripts", "validate-configs.test.ts"));
+  assert.equal(commands[2]?.cwd, tempDir);
+  assert.equal(commands[2]?.timeoutMs, 123_456);
 });
 
 test("runTestCli rejects malformed runtime binary overrides before dispatch", async (t) => {

scripts/test.mjs

@@ -613,13 +613,19 @@ export async function runTestCli(options = {}) {
     return 0;
   }
 
-  code = await runCommand(
-    bunBinary,
-    ["test", "--max-concurrency=1", "--timeout=120000", ...discovered.scriptTestFiles],
-    { cwd: root, env, timeoutMs: commandTimeoutMs, io },
-  );
+  for (const scriptTestFile of discovered.scriptTestFiles) {
+    code = await runCommand(
+      bunBinary,
+      ["test", "--max-concurrency=1", "--timeout=120000", scriptTestFile],
+      { cwd: root, env, timeoutMs: commandTimeoutMs, io },
+    );
+
+    if (code !== 0) {
+      return code;
+    }
+  }
 
-  return code;
+  return 0;
 }
 
 export async function runTestRunnerCli(options = {}, io = process) {