feat(workspaces): bake skills CLI 1.5.14 into claude-cli and interactive-tmux images#230
Merged
Merged
Conversation
…ive-tmux images Verified empirically against the built images: - skills --version reports 1.5.14 in both images. - Agent key vocabulary confirmed: claude-code, codex, gemini-cli (alias gemini maps to gemini-cli internally) - matches Task 9's _SKILLS_CLI_AGENT_KEYS table exactly, no changes needed there. - Local-path `skills add <path> --agent claude-code -y` installs project-relative to cwd at ./.claude/skills/<name>, not into the home directory. Confirms Task 9's execute() call already passing working_directory="/workspace" is correct and required.
There was a problem hiding this comment.
Pull request overview
Adds the skills npm CLI (pinned to 1.5.14) into the two workspace provider images so agents can perform harness-agnostic skill injection inside the containerized workspace environment.
Changes:
- Install
skills@1.5.14into theinteractive-tmuxworkspace image alongside the other bundled CLIs and verify it withskills --version. - Install
skills@1.5.14into theclaude-cliworkspace image via a dedicated npm global install step.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| providers/workspaces/interactive-tmux/Dockerfile | Adds skills@1.5.14 to the global npm installs and verifies it during build. |
| providers/workspaces/claude-cli/Dockerfile | Adds a global npm install step to bake skills@1.5.14 into the claude-cli workspace image. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+100
to
+101
| # Install the skills CLI globally via npm. Pin exact version deliberately. | ||
| RUN npm install -g skills@1.5.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
RUN npm install -g skills@1.5.14(exact pin, one transitive dep: yaml) to both workspace images, enabling harness-agnostic skill injection from syntropic137 (syntropic137/syntropic137#772, PR syntropic137/syntropic137#774).Verified locally before push (hard rule):
scripts/build-provider.pyskills --version= 1.5.14 in-imageclaude-code,codex,gemini-cli(aliasgemini -> gemini-cli)./.claude/skills/<name>), matching the consumer'sworking_directory=/workspaceinvocationConsumer lands in syntropic137/syntropic137#774; that repo's submodule pin bumps after this merges.