Skip to content

fix(itmux): skip codex plugins/ dir during auth staging #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NeuralEmpowerment wants to merge 1 commit into from
Closed

fix(itmux): skip codex plugins/ dir during auth staging #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions providers/workspaces/interactive-tmux/driver-rs/src/auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,10 @@ pub fn prepare_codex(host_src: &Path, ctx: &AuthContext) -> Result<PreparedAuth>
}
let dst_dir = ctx.throwaway_dir.join("codex.dir");
// Skip tmp/log/logs: codex races there during normal operation. The auth
// surface lives at `auth.json` / `config.toml` / `sessions/`.
copy_tree(host_src, &dst_dir, &["tmp", "log", "logs"])?;
// surface lives at `auth.json` / `config.toml` / `sessions/`. Also skip
// plugins/: a large plugin/dependency cache (node_modules), never auth,
// and staging it turns start_workspace into a multi-minute crawl.
copy_tree(host_src, &dst_dir, &["tmp", "log", "logs", "plugins"])?;
Ok(PreparedAuth(vec![StagedPath {
host: dst_dir,
container: "/home/agent/.codex".to_string(),
Expand Down
5 changes: 4 additions & 1 deletion providers/workspaces/interactive-tmux/driver-rs/tests/auth_parity.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,13 +161,15 @@ fn gemini_patches_folder_trust_in_settings() {
}

#[test]
fn codex_skips_tmp_and_log_subdirs() {
fn codex_skips_tmp_log_and_plugins_subdirs() {
let host = tmp("codex-host");
fs::create_dir_all(host.join("tmp")).unwrap();
fs::create_dir_all(host.join("log")).unwrap();
fs::create_dir_all(host.join("plugins")).unwrap();
fs::create_dir_all(host.join("sessions")).unwrap();
fs::write(host.join("tmp").join("racy-argv.bin"), b"vanish").unwrap();
fs::write(host.join("log").join("verbose.log"), b"noisy").unwrap();
fs::write(host.join("plugins").join("node_modules_stub"), b"heavy").unwrap();
fs::write(host.join("auth.json"), b"{}").unwrap();
fs::write(host.join("sessions").join("01.json"), b"{}").unwrap();

Expand All @@ -183,4 +185,5 @@ fn codex_skips_tmp_and_log_subdirs() {
assert!(dst.join("sessions").join("01.json").is_file());
assert!(!dst.join("tmp").exists(), "tmp/ must be skipped");
assert!(!dst.join("log").exists(), "log/ must be skipped");
assert!(!dst.join("plugins").exists(), "plugins/ must be skipped");
}
Loading