fix(sync): surface invalid subscription entries in stdout summary

Resolves four pre-existing test failures across claude, codex, and bob
sync tests that asserted "invalid subscription name" appeared in stdout
when an entry in evolve.config.yaml had an unsafe name (e.g.
'../evil', '.', '..').

Root cause: every platform's sync.py used `normalize_repos(cfg)`,
which routes through `_coerce_repo` in lib/config.py. _coerce_repo
silently filtered invalid entries (after a stray stderr print with a
slightly different phrasing — "ignoring repo entry 'X' — invalid
name") and returned None. The downstream "skipped — invalid
subscription name" branch in each sync.py ran on already-filtered
entries, so it never fired. The user saw "No subscriptions
configured" and a stderr log with a different message; the tests saw
neither in stdout.

Fix:

- lib/config.py: drop the stderr prints inside _coerce_repo. They
  were leaky from a library function (callers, not the lib, should
  decide where to surface a rejection). Add `classify_repo_entry`
  which returns (repo, rejection) for one raw entry — exactly one is
  non-None — so callers can iterate raw `cfg["repos"]` and report
  rejections per their own UX.

- claude/claw-code/codex/bob sync.py: replace `normalize_repos(cfg)`
  with manual iteration over raw entries via classify_repo_entry.
  Rejection reasons are added to the same `summaries` list that
  already collects per-repo sync results, so they appear in the
  user-visible "Synced N repo(s): …" stdout line. Dedup by name is
  preserved inline.

- test_config.py::test_invalid_scope_entries_dropped: replaced its
  capsys assertion (which depended on the now-removed stderr print)
  with a direct call to classify_repo_entry that returns the same
  rejection reason structurally.

Test impact:

- Fixes test_sync.py::test_skips_invalid_subscription_name
- Fixes test_bob_sharing.py::test_skips_invalid_subscription_name
- Fixes test_bob_sharing.py::test_rejects_dot_and_double_dot_names
- Fixes test_codex_sharing.py::test_sync_skips_invalid_subscription_name
- One pre-existing failure remains: test_subscribe_warns_when_audit_write_fails
  in test_codex_sharing.py. That test asserts subscribe.py warns and
  continues when the audit log can't be written; the current
  subscribe.py rolls back and exits 1 (claude and codex both). That's
  a separate design decision (fail-open UX vs fail-closed security)
  that deserves its own focused commit.

Refs #219

Author: illeatmyhat

platform-integrations/bob/evolve-lite/skills/evolve-lite-sync/scripts/sync.py

@@ -24,7 +24,7 @@
         break
 
 from audit import append as audit_append  # noqa: E402
-from config import is_valid_repo_name, load_config, normalize_repos  # noqa: E402
+from config import classify_repo_entry, load_config  # noqa: E402
 
 
 _GIT_TIMEOUT = 30  # seconds
@@ -107,11 +107,27 @@ def main():
         project_root = "."
 
     cfg = load_config(project_root)
-    repos = normalize_repos(cfg)
 
-    if not repos:
+    raw_entries = cfg.get("repos") if isinstance(cfg, dict) else None
+    if not isinstance(raw_entries, list):
+        raw_entries = []
+
+    repos = []
+    rejections = []
+    seen = set()
+    for entry in raw_entries:
+        repo, rejection = classify_repo_entry(entry)
+        if rejection is not None:
+            rejections.append(rejection)
+            continue
+        if repo["name"] in seen:
+            continue
+        seen.add(repo["name"])
+        repos.append(repo)
+
+    if not repos and not rejections:
         if not args.quiet:
-            print("No subscriptions configured. Add one with the evolve-lite:subscribe skill to start syncing shared guidelines.")
+            print("No subscriptions configured. Add one with the evolve-lite-subscribe skill to start syncing shared guidelines.")
         sys.exit(0)
 
     identity = cfg.get("identity", {})
@@ -121,22 +137,18 @@ def main():
     total_delta = {}
     any_changes = False
 
+    for rejection in rejections:
+        raw_name = rejection["raw_name"]
+        reason = rejection["reason"]
+        label = repr(raw_name) if raw_name else "<unnamed entry>"
+        summaries.append(f"{label} (skipped — {reason})")
+
     for repo in repos:
-        raw_name = repo.get("name", "unknown")
+        name = repo["name"]
         scope = repo.get("scope", "read")
         branch = repo.get("branch", "main")
         remote = repo.get("remote")
 
-        if not is_valid_repo_name(raw_name):
-            summaries.append(f"{raw_name!r} (skipped — invalid subscription name)")
-            continue
-        name = raw_name.strip()
-
-        if not isinstance(branch, str) or not branch.strip():
-            summaries.append(f"{raw_name!r} (skipped — invalid subscription config)")
-            continue
-        branch = branch.strip()
-
         subscribed_base = (evolve_dir / "entities" / "subscribed").resolve()
         repo_path = (evolve_dir / "entities" / "subscribed" / name).resolve()
 

platform-integrations/claude/plugins/evolve-lite/lib/config.py

@@ -7,7 +7,6 @@
 
 import pathlib
 import re
-import sys
 
 
 VALID_SCOPES = ("read", "write")
@@ -328,29 +327,26 @@ def save_config(cfg, project_root="."):
 
 
 def _coerce_repo(entry):
-    """Normalize a single repo dict. Returns None if required fields are missing."""
+    """Normalize a single repo dict. Returns None if required fields are missing.
+
+    Rejection is silent — callers that want to surface why a particular entry
+    was dropped should use ``classify_repo_entry`` to get the rejection reason
+    and report it however they choose.
+    """
     if not isinstance(entry, dict):
         return None
     name = entry.get("name")
     remote = entry.get("remote")
     if not isinstance(name, str) or not name.strip():
         return None
     if not is_valid_repo_name(name.strip()):
-        print(
-            f"evolve-lite: ignoring repo entry {name!r} — invalid name (only A-Z, a-z, 0-9, '.', '_', '-' allowed)",
-            file=sys.stderr,
-        )
         return None
     if not isinstance(remote, str) or not remote.strip():
         return None
     scope = entry.get("scope", "read")
     if isinstance(scope, str):
         scope = scope.strip()
     if scope not in VALID_SCOPES:
-        print(
-            f"evolve-lite: ignoring repo entry {name!r} — unknown scope {entry.get('scope')!r} (expected one of {', '.join(VALID_SCOPES)})",
-            file=sys.stderr,
-        )
         return None
     branch = entry.get("branch", "main")
     if not isinstance(branch, str) or not branch.strip():
@@ -389,6 +385,51 @@ def normalize_repos(cfg):
     return result
 
 
+def classify_repo_entry(entry):
+    """Return ``(repo, rejection)`` for one raw ``repos:`` list entry.
+
+    Exactly one of ``repo`` or ``rejection`` is non-None:
+      - ``repo`` is the normalized dict (same shape as ``normalize_repos``
+        items) when the entry is valid.
+      - ``rejection`` is a dict ``{"raw_name": str_or_None, "reason": str}``
+        describing why the entry was dropped. ``reason`` is one of
+        "invalid subscription name", "missing remote", "unknown scope", or
+        "malformed entry".
+
+    Used by sync.py (and similar) to surface skipped entries in user-facing
+    output without re-implementing validation.
+    """
+    if not isinstance(entry, dict):
+        return None, {"raw_name": None, "reason": "malformed entry"}
+    raw_name = entry.get("name")
+    if not isinstance(raw_name, str) or not raw_name.strip():
+        return None, {"raw_name": raw_name, "reason": "invalid subscription name"}
+    name = raw_name.strip()
+    if not is_valid_repo_name(name):
+        return None, {"raw_name": raw_name, "reason": "invalid subscription name"}
+    remote = entry.get("remote")
+    if not isinstance(remote, str) or not remote.strip():
+        return None, {"raw_name": raw_name, "reason": "missing remote"}
+    scope = entry.get("scope", "read")
+    if isinstance(scope, str):
+        scope = scope.strip()
+    if scope not in VALID_SCOPES:
+        return None, {"raw_name": raw_name, "reason": "unknown scope"}
+    branch = entry.get("branch", "main")
+    if not isinstance(branch, str) or not branch.strip():
+        branch = "main"
+    notes = entry.get("notes", "")
+    if not isinstance(notes, str):
+        notes = ""
+    return {
+        "name": name,
+        "scope": scope,
+        "remote": remote.strip(),
+        "branch": branch.strip(),
+        "notes": notes,
+    }, None
+
+
 def get_repo(cfg, name):
     """Return the repo with the given name, or None."""
     for repo in normalize_repos(cfg):

platform-integrations/claude/plugins/evolve-lite/skills/sync/scripts/sync.py

@@ -21,7 +21,7 @@
 
 # Add lib to path
 sys.path.insert(0, str(Path(__file__).resolve().parent.parent.parent.parent / "lib"))
-from config import is_valid_repo_name, load_config, normalize_repos  # noqa: E402
+from config import classify_repo_entry, load_config  # noqa: E402
 from audit import append as audit_append  # noqa: E402
 
 
@@ -149,9 +149,24 @@ def main():
     if args.session_start and isinstance(sync_cfg, dict) and sync_cfg.get("on_session_start") is False:
         sys.exit(0)
 
-    repos = normalize_repos(cfg)
+    raw_entries = cfg.get("repos") if isinstance(cfg, dict) else None
+    if not isinstance(raw_entries, list):
+        raw_entries = []
+
+    repos = []
+    rejections = []
+    seen = set()
+    for entry in raw_entries:
+        repo, rejection = classify_repo_entry(entry)
+        if rejection is not None:
+            rejections.append(rejection)
+            continue
+        if repo["name"] in seen:
+            continue
+        seen.add(repo["name"])
+        repos.append(repo)
 
-    if not repos:
+    if not repos and not rejections:
         if not args.quiet:
             print("No subscriptions configured. Add one with /evolve-lite:subscribe to start syncing shared guidelines.")
         sys.exit(0)
@@ -163,16 +178,18 @@ def main():
     total_delta = {}
     any_changes = False
 
+    for rejection in rejections:
+        raw_name = rejection["raw_name"]
+        reason = rejection["reason"]
+        label = repr(raw_name) if raw_name else "<unnamed entry>"
+        summaries.append(f"{label} (skipped — {reason})")
+
     for repo in repos:
         name = repo.get("name")
         scope = repo.get("scope", "read")
         branch = repo.get("branch", "main")
         remote = repo.get("remote")
 
-        if not is_valid_repo_name(name):
-            summaries.append(f"{name!r} (skipped — invalid subscription name)")
-            continue
-
         repo_path = evolve_dir / "entities" / "subscribed" / name
 
         head_before = None

platform-integrations/claw-code/plugins/evolve-lite/lib/config.py

@@ -7,7 +7,6 @@
 
 import pathlib
 import re
-import sys
 
 
 VALID_SCOPES = ("read", "write")
@@ -328,29 +327,26 @@ def save_config(cfg, project_root="."):
 
 
 def _coerce_repo(entry):
-    """Normalize a single repo dict. Returns None if required fields are missing."""
+    """Normalize a single repo dict. Returns None if required fields are missing.
+
+    Rejection is silent — callers that want to surface why a particular entry
+    was dropped should use ``classify_repo_entry`` to get the rejection reason
+    and report it however they choose.
+    """
     if not isinstance(entry, dict):
         return None
     name = entry.get("name")
     remote = entry.get("remote")
     if not isinstance(name, str) or not name.strip():
         return None
     if not is_valid_repo_name(name.strip()):
-        print(
-            f"evolve-lite: ignoring repo entry {name!r} — invalid name (only A-Z, a-z, 0-9, '.', '_', '-' allowed)",
-            file=sys.stderr,
-        )
         return None
     if not isinstance(remote, str) or not remote.strip():
         return None
     scope = entry.get("scope", "read")
     if isinstance(scope, str):
         scope = scope.strip()
     if scope not in VALID_SCOPES:
-        print(
-            f"evolve-lite: ignoring repo entry {name!r} — unknown scope {entry.get('scope')!r} (expected one of {', '.join(VALID_SCOPES)})",
-            file=sys.stderr,
-        )
         return None
     branch = entry.get("branch", "main")
     if not isinstance(branch, str) or not branch.strip():
@@ -389,6 +385,51 @@ def normalize_repos(cfg):
     return result
 
 
+def classify_repo_entry(entry):
+    """Return ``(repo, rejection)`` for one raw ``repos:`` list entry.
+
+    Exactly one of ``repo`` or ``rejection`` is non-None:
+      - ``repo`` is the normalized dict (same shape as ``normalize_repos``
+        items) when the entry is valid.
+      - ``rejection`` is a dict ``{"raw_name": str_or_None, "reason": str}``
+        describing why the entry was dropped. ``reason`` is one of
+        "invalid subscription name", "missing remote", "unknown scope", or
+        "malformed entry".
+
+    Used by sync.py (and similar) to surface skipped entries in user-facing
+    output without re-implementing validation.
+    """
+    if not isinstance(entry, dict):
+        return None, {"raw_name": None, "reason": "malformed entry"}
+    raw_name = entry.get("name")
+    if not isinstance(raw_name, str) or not raw_name.strip():
+        return None, {"raw_name": raw_name, "reason": "invalid subscription name"}
+    name = raw_name.strip()
+    if not is_valid_repo_name(name):
+        return None, {"raw_name": raw_name, "reason": "invalid subscription name"}
+    remote = entry.get("remote")
+    if not isinstance(remote, str) or not remote.strip():
+        return None, {"raw_name": raw_name, "reason": "missing remote"}
+    scope = entry.get("scope", "read")
+    if isinstance(scope, str):
+        scope = scope.strip()
+    if scope not in VALID_SCOPES:
+        return None, {"raw_name": raw_name, "reason": "unknown scope"}
+    branch = entry.get("branch", "main")
+    if not isinstance(branch, str) or not branch.strip():
+        branch = "main"
+    notes = entry.get("notes", "")
+    if not isinstance(notes, str):
+        notes = ""
+    return {
+        "name": name,
+        "scope": scope,
+        "remote": remote.strip(),
+        "branch": branch.strip(),
+        "notes": notes,
+    }, None
+
+
 def get_repo(cfg, name):
     """Return the repo with the given name, or None."""
     for repo in normalize_repos(cfg):

platform-integrations/claw-code/plugins/evolve-lite/skills/sync/scripts/sync.py

@@ -21,7 +21,7 @@
 
 # Add lib to path
 sys.path.insert(0, str(Path(__file__).resolve().parent.parent.parent.parent / "lib"))
-from config import is_valid_repo_name, load_config, normalize_repos  # noqa: E402
+from config import classify_repo_entry, load_config  # noqa: E402
 from audit import append as audit_append  # noqa: E402
 
 
@@ -149,9 +149,24 @@ def main():
     if args.session_start and isinstance(sync_cfg, dict) and sync_cfg.get("on_session_start") is False:
         sys.exit(0)
 
-    repos = normalize_repos(cfg)
+    raw_entries = cfg.get("repos") if isinstance(cfg, dict) else None
+    if not isinstance(raw_entries, list):
+        raw_entries = []
+
+    repos = []
+    rejections = []
+    seen = set()
+    for entry in raw_entries:
+        repo, rejection = classify_repo_entry(entry)
+        if rejection is not None:
+            rejections.append(rejection)
+            continue
+        if repo["name"] in seen:
+            continue
+        seen.add(repo["name"])
+        repos.append(repo)
 
-    if not repos:
+    if not repos and not rejections:
         if not args.quiet:
             print("No subscriptions configured. Add one with /evolve-lite:subscribe to start syncing shared guidelines.")
         sys.exit(0)
@@ -163,16 +178,18 @@ def main():
     total_delta = {}
     any_changes = False
 
+    for rejection in rejections:
+        raw_name = rejection["raw_name"]
+        reason = rejection["reason"]
+        label = repr(raw_name) if raw_name else "<unnamed entry>"
+        summaries.append(f"{label} (skipped — {reason})")
+
     for repo in repos:
         name = repo.get("name")
         scope = repo.get("scope", "read")
         branch = repo.get("branch", "main")
         remote = repo.get("remote")
 
-        if not is_valid_repo_name(name):
-            summaries.append(f"{name!r} (skipped — invalid subscription name)")
-            continue
-
         repo_path = evolve_dir / "entities" / "subscribed" / name
 
         head_before = None