fix(platform-integrations): add missing entity_io lib to Bob (#105)

* fix(platform-integrations): add missing entity_io lib to Bob integration
* refactor(platform-integrations): use single shared lib and rename to kaizen-lib
* fix(entity_io): honor KAIZEN_ENTITIES_DIR in get_default_entities_dir
* fix(entity_io): persist normalized type value before serialization
* fix(entity_io): use atomic claim loop and os.replace for cross-platform compatibility
* fix(platform-integrations): guard against missing shared lib in Bob install
* fix(bob): replace hardcoded path traversal with walk-up search for kaizen-lib
* fix(bob): suppress E402 lint for entity_io imports after sys.path setup
* fix(entity_io): clean up 0-byte orphan target file on write failure

Author: vinodmut

platform-integrations/bob/kaizen-lite/skills/kaizen-learn/scripts/save_entities.py

@@ -9,9 +9,18 @@
 import sys
 from pathlib import Path
 
-# Add lib to path so we can import entity_io
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent.parent.parent / "lib"))
-from entity_io import (
+# Walk up from script to find kaizen-lib
+_script = Path(__file__).resolve()
+_lib = None
+for _ancestor in _script.parents:
+    _candidate = _ancestor / "kaizen-lib"
+    if _candidate.is_dir():
+        _lib = _candidate
+        break
+if _lib is None:
+    raise ImportError(f"Cannot find kaizen-lib directory above {_script}")
+sys.path.insert(0, str(_lib))
+from entity_io import (  # noqa: E402
     find_entities_dir,
     get_default_entities_dir,
     load_all_entities,

platform-integrations/bob/kaizen-lite/skills/kaizen-recall/scripts/retrieve_entities.py

@@ -6,9 +6,18 @@
 import sys
 from pathlib import Path
 
-# Add lib to path so we can import entity_io
-sys.path.insert(0, str(Path(__file__).resolve().parent.parent.parent.parent / "lib"))
-from entity_io import find_entities_dir, load_all_entities, log as _log
+# Walk up from script to find kaizen-lib
+_script = Path(__file__).resolve()
+_lib = None
+for _ancestor in _script.parents:
+    _candidate = _ancestor / "kaizen-lib"
+    if _candidate.is_dir():
+        _lib = _candidate
+        break
+if _lib is None:
+    raise ImportError(f"Cannot find kaizen-lib directory above {_script}")
+sys.path.insert(0, str(_lib))
+from entity_io import find_entities_dir, load_all_entities, log as _log  # noqa: E402
 
 
 def log(message):

platform-integrations/claude/plugins/kaizen-lite/lib/entity_io.py

@@ -84,9 +84,16 @@ def find_entities_dir():
 def get_default_entities_dir():
     """Return (and create) the default entities directory.
 
-    Prefers ``{CLAUDE_PROJECT_ROOT}/.kaizen/entities/``, falls back to
+    Prefers ``KAIZEN_ENTITIES_DIR``, then
+    ``{CLAUDE_PROJECT_ROOT}/.kaizen/entities/``, falls back to
     ``.kaizen/entities/``.
     """
+    env_dir = os.environ.get("KAIZEN_ENTITIES_DIR")
+    if env_dir:
+        base = Path(env_dir)
+        base.mkdir(parents=True, exist_ok=True)
+        return base.resolve()
+
     project_root = os.environ.get("CLAUDE_PROJECT_ROOT", "")
     if project_root:
         base = Path(project_root) / ".kaizen" / "entities"
@@ -258,6 +265,7 @@ def write_entity_file(directory, entity):
     entity_type = entity.get("type", "general")
     if not re.fullmatch(r"[a-z0-9][a-z0-9_-]*", entity_type):
         entity_type = "general"
+    entity["type"] = entity_type
     type_dir = Path(directory) / entity_type
     type_dir.mkdir(parents=True, exist_ok=True)
 
@@ -271,20 +279,24 @@ def write_entity_file(directory, entity):
         os.close(fd)
         fd = None
 
-        # Atomically claim the target using O_EXCL to detect races
-        target = unique_filename(type_dir, slug)
-        try:
-            claim_fd = os.open(str(target), os.O_CREAT | os.O_EXCL | os.O_WRONLY)
-            os.close(claim_fd)
-        except FileExistsError:
-            # Another writer beat us — re-discover a free name
+        # Atomically claim the target using O_EXCL; retry on race
+        while True:
             target = unique_filename(type_dir, slug)
-
-        os.rename(tmp_path, target)
+            try:
+                claim_fd = os.open(str(target), os.O_CREAT | os.O_EXCL | os.O_WRONLY)
+                os.close(claim_fd)
+                break
+            except FileExistsError:
+                continue
+
+        os.replace(tmp_path, target)
         return target
     except BaseException:
         if fd is not None:
             os.close(fd)
         if os.path.exists(tmp_path):
             os.unlink(tmp_path)
+        # Clean up the 0-byte placeholder if the replace didn't happen
+        if target and os.path.exists(str(target)) and os.path.getsize(str(target)) == 0:
+            os.unlink(str(target))
         raise

platform-integrations/install.sh

@@ -502,6 +502,14 @@ def install_bob(source_dir, target_dir, mode="lite"):
 
     info(f"Installing Bob ({mode} mode) → {bob_target}")
 
+    # Shared lib (entity_io) — single source of truth lives in the Claude plugin
+    shared_lib = Path(source_dir) / "platform-integrations" / "claude" / "plugins" / "kaizen-lite" / "lib"
+    if not shared_lib.is_dir():
+        error(f"Shared lib not found: {shared_lib} — is the Claude plugin present in the source tree?")
+        sys.exit(1)
+    copy_tree(shared_lib, bob_target / "kaizen-lib")
+    success("Copied Bob lib")
+
     # Skills
     copy_tree(bob_source_lite / "skills" / "kaizen-learn",  bob_target / "skills" / "kaizen-learn")
     copy_tree(bob_source_lite / "skills" / "kaizen-recall", bob_target / "skills" / "kaizen-recall")
@@ -537,6 +545,7 @@ def uninstall_bob(target_dir, mode="full"):
     bob_target = Path(target_dir) / ".bob"
     info(f"Uninstalling Bob from {bob_target}")
 
+    remove_dir(bob_target / "kaizen-lib")
     remove_dir(bob_target / "skills" / "kaizen-learn")
     remove_dir(bob_target / "skills" / "kaizen-recall")
     remove_file(bob_target / "commands" / "kaizen:learn.md")
@@ -550,6 +559,7 @@ def uninstall_bob(target_dir, mode="full"):
 def status_bob(target_dir):
     bob_target = Path(target_dir) / ".bob"
     print(f"  Bob (.bob/):")
+    print(f"    kaizen-lib/entity_io  : {'✓' if (bob_target / 'kaizen-lib' / 'entity_io.py').is_file() else '✗'}")
     print(f"    skills/kaizen-learn  : {'✓' if (bob_target / 'skills' / 'kaizen-learn').is_dir() else '✗'}")
     print(f"    skills/kaizen-recall : {'✓' if (bob_target / 'skills' / 'kaizen-recall').is_dir() else '✗'}")
     print(f"    commands/            : {'✓' if (bob_target / 'commands' / 'kaizen:learn.md').is_file() else '✗'}")