Update pyproject.toml#125
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughUpdated dependency version constraints in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Line 15: The pyproject.toml dependency floor for "milvus-lite>=2.5.1;
platform_machine != 'aarch64'" risks pulling a pymilvus older than 2.6.2 (which
provides partial_update used in evolve/backend/milvus.py around the upsert
call), so update pyproject.toml to either raise the milvus-lite minimum to a
release that transitively requires pymilvus>=2.6.2 or add an explicit direct
requirement "pymilvus>=2.6.2" to ensure partial_update is available at runtime.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
Please comment on the coderabbit reviews. |
|
the reason we’re waiting on 2.5.2 is because it will fail to install otherwise because of a problem caused by sqlean-py |
The test passed though, should we stick with pre-release version or 2.5.1, the problem of pre-release version is because when ever you want to have uv sync we need to allow using --prerelease |
|
well if it passes thats cool I guess |
pre-release version is blocked by uv lock is there any specific feature we need from milvu-lite 2.5.2?
Summary by CodeRabbit