Skip to content

Update pyproject.toml#125

Merged
gaodan-fang merged 4 commits into
mainfrom
gaodan-fang-patch-4
Apr 2, 2026
Merged

Update pyproject.toml#125
gaodan-fang merged 4 commits into
mainfrom
gaodan-fang-patch-4

Conversation

@gaodan-fang

@gaodan-fang gaodan-fang commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

pre-release version is blocked by uv lock is there any specific feature we need from milvu-lite 2.5.2?

Summary by CodeRabbit

  • Chores
    • Updated Milvus-related dependency version constraints to newer releases (pymilvus and milvus-lite updated to the latest compatible ranges), including platform-specific adjustments for aarch64 and non-aarch64 builds. This improves compatibility and stability of local and platform-specific installations without changing public APIs or exported interfaces.

@gaodan-fang gaodan-fang requested a review from illeatmyhat April 1, 2026 18:30
@coderabbitai

coderabbitai Bot commented Apr 1, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8af8dffa-035c-49e9-bbe2-67e3c867e485

📥 Commits

Reviewing files that changed from the base of the PR and between c20ac25 and eeb67e8.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml
✅ Files skipped from review due to trivial changes (1)
  • pyproject.toml

📝 Walkthrough

Walkthrough

Updated dependency version constraints in pyproject.toml: pymilvus changed to >=2.6.2 for all platforms; for non-aarch64, pymilvus[milvus-lite] set to >=2.6.2 and milvus-lite set to >=2.5.1. No code changes.

Changes

Cohort / File(s) Summary
Dependency Version Updates
pyproject.toml
Bumped pymilvus constraint to >=2.6.2 (applies to both platform_machine == 'aarch64' and others). For platform_machine != 'aarch64', set pymilvus[milvus-lite] >=2.6.2 and milvus-lite >=2.5.1. No other edits.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • visahak

Poem

🐰 I hopped through toml lines, nibbling at a version seed,
Lifted pymilvus higher, gave milvus-lite a gentle feed,
ARM and non‑ARM notes, written tidy and neat,
No source was harmed — just package numbers to meet,
Thump-thump, I celebrate this small, precise deed 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update pyproject.toml' is vague and generic, using non-descriptive terms that don't convey what specific changes were made or why. Consider a more specific title such as 'Update Milvus dependencies to version 2.6.2' or 'Bump pymilvus and milvus-lite versions in pyproject.toml' to clearly indicate the main purpose of the changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gaodan-fang-patch-4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@pyproject.toml`:
- Line 15: The pyproject.toml dependency floor for "milvus-lite>=2.5.1;
platform_machine != 'aarch64'" risks pulling a pymilvus older than 2.6.2 (which
provides partial_update used in evolve/backend/milvus.py around the upsert
call), so update pyproject.toml to either raise the milvus-lite minimum to a
release that transitively requires pymilvus>=2.6.2 or add an explicit direct
requirement "pymilvus>=2.6.2" to ensure partial_update is available at runtime.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 921849b3-5495-4819-9cb7-e92b5c761016

📥 Commits

Reviewing files that changed from the base of the PR and between 824e4d9 and cd46a85.

📒 Files selected for processing (1)
  • pyproject.toml

Comment thread pyproject.toml
@vinodmut

vinodmut commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Please comment on the coderabbit reviews.

@illeatmyhat

Copy link
Copy Markdown
Collaborator

the reason we’re waiting on 2.5.2 is because it will fail to install otherwise because of a problem caused by sqlean-py
it was recently fixed but i dont think the update was pushed by milvus yet

@gaodan-fang

gaodan-fang commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator Author

the reason we’re waiting on 2.5.2 is because it will fail to install otherwise because of a problem caused by sqlean-py it was recently fixed but i dont think the update was pushed by milvus yet

The test passed though, should we stick with pre-release version or 2.5.1, the problem of pre-release version is because when ever you want to have uv sync we need to allow using --prerelease

@illeatmyhat

Copy link
Copy Markdown
Collaborator

well if it passes thats cool I guess

@gaodan-fang gaodan-fang merged commit 5652d4b into main Apr 2, 2026
16 checks passed
@visahak visahak deleted the gaodan-fang-patch-4 branch April 3, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants