Skip to content

feat(persona): add shared persona type package#94

Open
kjgbot wants to merge 1 commit into
mainfrom
ricky/sage-214-pr01a-persona-types
Open

feat(persona): add shared persona type package#94
kjgbot wants to merge 1 commit into
mainfrom
ricky/sage-214-pr01a-persona-types

Conversation

@kjgbot
Copy link
Copy Markdown

@kjgbot kjgbot commented May 22, 2026

Summary

  • Implements Sage #214 Appendix C PR-0.1a as the first focused Ricky-generated slice.
  • Adds the new @agent-assistant/persona workspace package with type-only persona contracts for executors, triggers, memory, delivery, and sandbox borrow config.
  • Registers the package in the root workspace and lockfile.

Scope

  • This PR is intentionally type-only.
  • Validators, JSON schema generation, dispatch/runtime wiring, Sage/cloud/workforce integration, and persona manifests are deferred to follow-up PR-0.1b/0.1c slices.

Ricky execution notes

  • Generated/executed via local Ricky against /private/tmp/sage-ricky-214-specs/pr-0.1a-agent-assistant-persona-types.md.
  • Ricky produced the implementation and final review artifacts with NO_ISSUES_FOUND.
  • Ricky runtime wrapper still reported UNSUPPORTED_RUNTIME after the foreground broker process was stopped from a post-review hang, and the generated validation gate failed to materialize the explicit spec commands. I therefore ran the exact spec validation manually after the Ricky run before pushing.

Validation

  • npm install --ignore-scripts
  • npm run -w @agent-assistant/persona build
  • npm run -w @agent-assistant/persona test
  • node -e "import('@agent-assistant/persona').then((m) => console.log(Object.keys(m).length))" -> 0
  • git diff --check

No merge performed.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 22, 2026

Warning

Rate limit exceeded

@kjgbot has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 35 minutes and 58 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bf012b6a-2095-48ab-bd47-7623c4b43af1

📥 Commits

Reviewing files that changed from the base of the PR and between 50a004b and d38d98e.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (6)
  • package.json
  • packages/persona/package.json
  • packages/persona/src/index.ts
  • packages/persona/src/types.test.ts
  • packages/persona/src/types.ts
  • packages/persona/tsconfig.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ricky/sage-214-pr01a-persona-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant