-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add OpenCode to spawn dialogs and empty-state UI #143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khaliqgant
wants to merge
4
commits into
main
Choose a base branch
from
claude/opencode-ui-only
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
eff02f5
feat: add OpenCode to spawn dialogs and empty-state UI
claude 3b52bec
feat: grey out spawn buttons when CLI is not installed
claude ed6285c
chore: apply pr-reviewer fixes for #143
agent-relay-code[bot] daf84ba
fix: guard cliAvailability setState against unmount
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| // Check if Object.fromEntries result is assignable to Partial<Record<SpawnAgentCli, boolean>> | ||
|
|
||
| // According to TypeScript: | ||
| // Partial<Record<SpawnAgentCli, boolean>> expands to: | ||
| // { claude?: boolean; codex?: boolean; opencode?: boolean } | ||
|
|
||
| // Object.fromEntries returns: { [k: string]: any } | ||
| // In the context of: | ||
| // const results: Array<[SpawnAgentCli, boolean]> = [['claude', true], ...] | ||
| // Object.fromEntries(results) is typed as: { [k: string]: boolean } | ||
|
|
||
| // The question: is { [k: string]: boolean } assignable to | ||
| // { claude?: boolean; codex?: boolean; opencode?: boolean }? | ||
|
|
||
| // Answer: YES, because: | ||
| // 1. { [k: string]: boolean } is an index signature that matches ANY string key | ||
| // 2. { claude?: boolean; codex?: boolean; opencode?: boolean } only uses specific keys | ||
| // 3. Any value with an index signature { [k: string]: T } satisfies a type with specific optional properties | ||
|
|
||
| console.log("Type check analysis:"); | ||
| console.log("Object.fromEntries(results) type: { [k: string]: boolean }"); | ||
| console.log("setCliAvailability expects: Partial<Record<SpawnAgentCli, boolean>>"); | ||
| console.log("Which expands to: { claude?: boolean; codex?: boolean; opencode?: boolean }"); | ||
| console.log(""); | ||
| console.log("TypeScript assignability: YES - index signature types are assignable to property-specific types"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of the
Iconproperty inAGENT_OPTIONSis hardcoded totypeof ClaudeIcon. While this works because all agent icons share the same signature, it is more idiomatic and maintainable to use a generic React component type. This prevents potential type issues when adding new agent icons with different implementations in the future.