Skip to content

DO-NOT-MERGE: Split #132 Slack integration event fix#145

Merged
khaliqgant merged 1 commit into
mainfrom
split/132-slack-integration-event-context-retry
Jun 7, 2026
Merged

DO-NOT-MERGE: Split #132 Slack integration event fix#145
khaliqgant merged 1 commit into
mainfrom
split/132-slack-integration-event-context-retry

Conversation

@kjgbot
Copy link
Copy Markdown
Contributor

@kjgbot kjgbot commented Jun 7, 2026

DO-NOT-MERGE: merge hold remains in force; this PR is opened for review only.

Split from #132 / fix/slack-integration-event-context-retry.

Summary:

  • Isolates the Slack integration event bridge half from the Slack integration event fixes + #125 workspace-key wiring #132 branch.
  • Keeps the change scoped to src/main/integration-event-bridge.ts and src/main/__tests__/integration-event-bridge.test.ts.
  • Allows a blind Slack logical injection claim to learn the later content-bearing alias hash, so duplicate alias delivery stays suppressed while a genuine edited message can still inject.

Restart-branch decision note:

Verification:

  • node --experimental-strip-types --no-warnings --test src/main/__tests__/integration-event-bridge.test.ts (58/58)
  • npm run build

Cross-link: #132

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 7, 2026

Warning

Review limit reached

@kjgbot, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 54 minutes and 52 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2399fcaf-d2b1-4f8d-9b67-697a92738e46

📥 Commits

Reviewing files that changed from the base of the PR and between 7187fee and b9cba58.

📒 Files selected for processing (2)
  • src/main/__tests__/integration-event-bridge.test.ts
  • src/main/integration-event-bridge.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch split/132-slack-integration-event-context-retry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IntegrationEventBridge logic to ensure that a blind claim (where the context read returned nothing) learns the content hash of a subsequent content-bearing alias copy, preventing genuine edits from being incorrectly suppressed. A corresponding integration test has been added to verify this behavior. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@agent-relay-code
Copy link
Copy Markdown
Contributor

⚠️ pr-reviewer did not push — the PR branch advanced during the review, so fixes were withheld to avoid overwriting newer commits. Re-trigger the review once the branch settles. The notes below are advisory and were not pushed.

Reviewed the PR artifacts and traced the changed broker/cloud-agent paths in the current checkout. The main regression I suspected from .workforce/pr.diff had already been fixed in the actual tree: spawn results are clone-safe and persona spawns are coalesced, with regression coverage present.

Local verification passed:

  • npx vitest run src/main/broker.test.ts src/main/cloud-agent.test.ts - 60 passed
  • npm run build - passed
  • npm test - 88 passed

Note: .workforce/context.json identifies this checkout as PR #146, while the task text says #145; I reviewed the checked-out PR artifacts as requested. I did not print READY because I cannot verify GitHub-side CI status or mergeability from this sandbox.

@kjgbot kjgbot marked this pull request as ready for review June 7, 2026 15:57
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@agent-relay-code
Copy link
Copy Markdown
Contributor

Reviewed PR #145 against .workforce/pr.diff, changed files, context, surrounding callers, and PR bot comments. I found no current breakage to fix, so I left the PR code unchanged.

Validation run locally:

  • npm ci
  • npm run verify:mcp-resources-drift
  • npm test - 89 passed
  • npx vitest run src/main/broker.test.ts - 36 passed
  • npm run build - passed
  • Final npm run verify:mcp-resources-drift - passed

Bot/reviewer comments had no actionable current findings: CodeRabbit was rate-limited, Gemini/cubic/Devin reported no issues, and the older pr-reviewer note was stale/advisory for a different checkout shape.

I’m not printing READY because I cannot verify GitHub-side CI completion/mergeability from here.

@khaliqgant khaliqgant merged commit fe72ac1 into main Jun 7, 2026
5 checks passed
@khaliqgant khaliqgant deleted the split/132-slack-integration-event-context-retry branch June 7, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants