Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 70 additions & 0 deletions src/main/__tests__/integration-event-bridge.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -776,6 +776,76 @@ test('slack raw-id and slug alias duplicates suppress when one context read is s
assert.match(harness.sent[0].input.text, /Message:\nreadable Slack message/u)
})

test('slack edits after a blind alias claim still inject once the content changes', async () => {
let messageText = 'original Slack message'
const harness = makeHarness(['alice'], {
readFileResponse: (_workspaceId, path) => {
if (!path.includes('__proj-cloud')) throw new Error('remote file not ready')
return {
path,
revision: 'rev-context',
contentType: 'application/json',
content: JSON.stringify({ provider: 'slack', text: messageText }),
encoding: 'utf-8'
}
}
})

await withMockedNow('2026-06-05T14:00:00.000Z', async () => {
await harness.bridge.reconcile('project-1', [
integration({
provider: 'slack',
integrationId: 'slack-1',
mountPaths: ['/slack/channels/C123ABC__proj-cloud'],
downloadHistoricalData: false,
scope: { notifyAgents: ['alice'] }
})
])
})

// Raw-id copy first: every targeted read fails and the expanded event only
// carries the sparse relayfile pointer, so the injection is blind.
await harness.emit({
...changeEvent(
'/slack/channels/C123ABC/messages/1780668000_000000/meta.json',
'slack',
{ digest: 'revision:raw-copy' }
),
expand: async () => ({
level: 'full',
path: '/slack/channels/C123ABC/messages/1780668000_000000/meta.json',
data: {
path: '/slack/channels/C123ABC/messages/1780668000_000000/meta.json',
deleted: false
}
})
} as ChangeEvent)
await waitForSent(harness, 1, 2_500)
assert.equal(harness.sent.length, 1)
assert.match(harness.sent[0].input.text, /Message: unavailable; targeted context read did not return content\./u)

// The slug alias copy of the same record carries content: suppressed as a
// duplicate, but the claim learns the content hash.
await harness.emit(changeEvent(
'/slack/channels/C123ABC__proj-cloud/messages/1780668000_000000/meta.json',
'slack',
{ digest: 'revision:slug-copy' }
))
await waitForDropped('project-1', 1, 2_500)
assert.equal(harness.sent.length, 1)

// A genuine edit changes the content hash and must inject again.
messageText = 'edited Slack message'
await harness.emit(changeEvent(
'/slack/channels/C123ABC__proj-cloud/messages/1780668000_000000/meta.json',
'slack',
{ digest: 'revision:slug-edit' }
))
await waitForSent(harness, 2)
assert.equal(harness.sent.length, 2)
assert.match(harness.sent[1].input.text, /Message:\nedited Slack message/u)
})

test('remote replayed events older than the subscription session are dropped by default', async () => {
const harness = makeHarness()

Expand Down
12 changes: 11 additions & 1 deletion src/main/integration-event-bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2581,7 +2581,17 @@ export class IntegrationEventBridge {
: undefined
const existing = this.slackLogicalInjections.get(key)
if (existing) {
if (!contentHash || !existing.contentHashes || existing.contentHashes.has(contentHash)) {
if (!contentHash) {
return false
}
if (!existing.contentHashes) {
// A blind claim (context read returned nothing) suppresses the late
// content-bearing alias copy, but must learn its hash so a genuine
// edit afterwards still injects instead of matching the blind claim.
existing.contentHashes = new Set([contentHash])
return false
}
if (existing.contentHashes.has(contentHash)) {
return false
}
existing.contentHashes.add(contentHash)
Expand Down
Loading