Skip to content

chore(trajectories): fix leaked index paths + quarantine invalid traces #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
khaliqgant wants to merge 1 commit into from
Closed

chore(trajectories): fix leaked index paths + quarantine invalid traces #891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .trajectories/index.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,14 +387,14 @@
"status": "completed",
"startedAt": "2026-05-11T18:43:20.429Z",
"completedAt": "2026-05-11T18:43:20.733Z",
"path": "/home/runner/work/relay/relay/.trajectories/completed/2026-05/traj_dpgn0am1jq1c.json"
"path": ".trajectories/completed/2026-05/traj_dpgn0am1jq1c.json"

@coderabbitai coderabbitai Bot May 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

❓ Verification inconclusive

Script executed:

#!/bin/bash
# Find all absolute path entries in the trajectory index

echo "=== Absolute paths still present in index.json ==="
rg -n '"path": "/' .trajectories/index.json | wc -l
echo "entries found."
echo ""
echo "Breakdown:"
rg -n '"path": "/' .trajectories/index.json

echo ""
echo "=== Expected relative path format ==="
echo "Should be: .trajectories/completed/YYYY-MM/<trajectory_id>.json"

Repository: AgentWorkforce/relay

Repository: AgentWorkforce/relay
Exit code: 0

stdout:

=== Absolute paths still present in index.json ===
20
entries found.

Breakdown:
404:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_wx00tjvpptvg.json"
411:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_whd40oxptlhn.json"
424:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_v1wexlfur5zr.json"
431:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_6sjeohtm3php.json"
487:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_n8duofq5vq1a.json"
494:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_7zu7et53ph3l.json"
501:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_2yicjxgajt0a.json"
508:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_hrsndfzk0qay.json"
515:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_4t07itef99ug.json"
522:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_947wzpddsg9j.json"
529:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_fh8oosbijpwc.json"
536:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_gh05rj5gwsap.json"
543:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_tgism98me5na.json"
550:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_zfa6skfr32vy.json"
557:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_3gjtcykvybt5.json"
564:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_o251whkvy9rl.json"
571:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_d89s38ddu7cj.json"
578:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_0e8i20oitwvz.json"
585:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_wzzboitm85ee.json"
592:      "path": "/Users/khaliqgant/Projects/AgentWorkforce/relay/.trajectories/completed/2026-05/traj_hfkww5z7trxn.json"

=== Expected relative path format ===
Should be: .trajectories/completed/YYYY-MM/<trajectory_id>.json

Incomplete path normalization leaves 20 entries with absolute paths.

The four changed entries correctly normalize leaked foreign paths to the repository convention. However, 20 entries still contain absolute paths from /Users/khaliqgant/Projects/AgentWorkforce/relay/... (lines 404, 411, 424, 431, 487, 494, 501, 508, 515, 522, 529, 536, 543, 550, 557, 564, 571, 578, 585, 592).

The stated problem is that "absolute/foreign paths" prevent reconciliation because trail cannot match them to actual files. This issue is not specific to foreign paths—the /Users/khaliqgant/... paths will fail reconciliation on CI or other developers' machines in exactly the same way /home/runner/... and /Users/will/... paths failed on your machine.

For true data hygiene and cross-environment portability, all absolute paths should be normalized to the .trajectories/completed/YYYY-MM/<id>.json convention.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.trajectories/index.json at line 390, The index file still contains 20
absolute/foreign file paths (e.g., entries with
"/Users/khaliqgant/Projects/AgentWorkforce/relay/...") that must be normalized
to the repository convention; locate the remaining offending entries in
.trajectories/index.json and replace each absolute path value with the relative
convention ".trajectories/completed/YYYY-MM/<id>.json" matching the actual
completed entry filenames (use the same YYYY-MM and id pattern used by the
already-corrected entries such as the existing
".trajectories/completed/2026-05/traj_dpgn0am1jq1c.json"), ensuring all path
fields are consistent and contain no absolute filesystem prefixes so
reconciliation will succeed across environments.

},
"traj_mi9eqd4rjfea": {
"title": "Address stdio fresh review findings",
"status": "abandoned",
"startedAt": "2026-05-11T18:25:24.626Z",
"completedAt": "2026-05-11T18:37:05.318Z",
"path": "/home/runner/work/relay/relay/.trajectories/completed/2026-05/traj_mi9eqd4rjfea.json"
"path": ".trajectories/completed/2026-05/traj_mi9eqd4rjfea.json"
},
"traj_wx00tjvpptvg": {
"title": "Investigate agent-relay spawn persistence",
Expand Down Expand Up @@ -603,7 +603,7 @@
"status": "completed",
"startedAt": "2026-05-18T02:02:07.524Z",
"completedAt": "2026-05-18T02:05:41.120Z",
"path": "/Users/will/Projects/AgentWorkforce/relay/.claude/worktrees/agent-a65b9343cd7dbadb3/.trajectories/completed/2026-05/traj_ybcrij9wg8m1.json"
"path": ".trajectories/completed/2026-05/traj_ybcrij9wg8m1.json"
},
"traj_piik8r6zu3i7": {
"title": "Issue 867: RelayEventListener",
Expand All @@ -617,7 +617,7 @@
"status": "completed",
"startedAt": "2026-05-18T02:56:55.314Z",
"completedAt": "2026-05-18T03:02:35.202Z",
"path": "/Users/will/Projects/AgentWorkforce/relay/.claude/worktrees/agent-aff3649a00a0f36ab/.trajectories/completed/2026-05/traj_ryf5sstno6p3.json"
"path": ".trajectories/completed/2026-05/traj_ryf5sstno6p3.json"
}
}
}
0 ...eted/2026-05/traj_fh8oosbijpwc.trace.json → ...eted/2026-05/traj_fh8oosbijpwc.trace.json
View file
Open in desktop
File renamed without changes.
0 ...eted/2026-05/traj_gh05rj5gwsap.trace.json → ...eted/2026-05/traj_gh05rj5gwsap.trace.json
View file
Open in desktop
File renamed without changes.
0 ...eted/2026-05/traj_lieyyspidhfj.trace.json → ...eted/2026-05/traj_lieyyspidhfj.trace.json
View file
Open in desktop
File renamed without changes.
0 ...eted/2026-05/traj_whd40oxptlhn.trace.json → ...eted/2026-05/traj_whd40oxptlhn.trace.json
View file
Open in desktop
File renamed without changes.
Loading