fix(workflow-runtime): tighten PTY chrome scrubbing, document idle override, tame stale-state warning #930
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /** | ||
| * Regression tests for WorkflowRunner.scrubForChannel — the function that | ||
| * strips PTY/TUI chrome from interactive-agent step output before it gets | ||
| * surfaced in workflow logs and channel messages. | ||
| * | ||
| * The patterns covered here are taken from a real captured run of a | ||
| * multi-turn workflow against Claude Code's PTY: when its TUI footer | ||
| * overwrites itself faster than the PTY flushes whitespace, lines like | ||
| * `bypasspermissionson`, `--INSERT--⏵⏵`, and `Opus 4.7 (1M context) ctx:5% | ||
| * $1.45` end up in the captured stream. Before these regex additions, the | ||
| * step "Output:" block was unreadable on interactive-agent steps. | ||
| */ | ||
| import { describe, it, expect } from 'vitest'; | ||
|
|
||
| import { WorkflowRunner } from '../runner.js'; | ||
|
|
||
| // scrubForChannel is `private static` — the cast is the minimal-invasive way | ||
| // to exercise it from a test without exporting an internal-only helper. | ||
| const scrub = (text: string): string => | ||
| (WorkflowRunner as unknown as { scrubForChannel(t: string): string }).scrubForChannel(text); | ||
|
|
||
| describe('WorkflowRunner.scrubForChannel — PTY chrome stripping', () => { | ||
| it('strips the Claude Code bottom status bar (model + ctx% + cost)', () => { | ||
| const input = [ | ||
| 'real content line', | ||
| 'workflows git:(main) Opus 4.7 (1M context) ctx:5% $1.45', | ||
| 'Opus4.7(1Mcontext) ctx:6% $1.54', | ||
| 'another real line', | ||
| ].join('\n'); | ||
| const out = scrub(input); | ||
| expect(out).toContain('real content line'); | ||
| expect(out).toContain('another real line'); | ||
| expect(out).not.toMatch(/ctx\s*:\s*\d+%/); | ||
| expect(out).not.toMatch(/\$\d+\.\d+/); | ||
| }); | ||
|
Comment on lines
+23
to
+35
Contributor
There was a problem hiding this comment. Assert full footer-line removal, not just token removal. This test can still pass if Suggested test tightening const out = scrub(input);
expect(out).toContain('real content line');
expect(out).toContain('another real line');
+ expect(out).not.toContain('workflows git:(main) Opus 4.7 (1M context) ctx:5% $1.45');
+ expect(out).not.toContain('Opus4.7(1Mcontext) ctx:6% $1.54');
expect(out).not.toMatch(/ctx\s*:\s*\d+%/);
expect(out).not.toMatch(/\$\d+\.\d+/);🤖 Prompt for AI Agents |
||
|
|
||
| it('strips vim-style mode indicators emitted by the input bar', () => { | ||
| const input = [ | ||
| 'pre-mode line', | ||
| '--INSERT--', | ||
| '--INSERT--⏵⏵bypasspermissionson (shift+tabtocycle)', | ||
| 'post-mode line', | ||
| ].join('\n'); | ||
| const out = scrub(input); | ||
| expect(out).toContain('pre-mode line'); | ||
| expect(out).toContain('post-mode line'); | ||
| expect(out).not.toMatch(/--INSERT--/); | ||
| }); | ||
|
|
||
| it('strips no-whitespace TUI hint variants (bypasspermissionson, pasteagaintoexpand)', () => { | ||
| const input = ['before', 'bypasspermissionson', 'pasteagaintoexpand', 'shifttabto cycle', 'after'].join( | ||
| '\n' | ||
| ); | ||
| const out = scrub(input); | ||
| expect(out).toContain('before'); | ||
| expect(out).toContain('after'); | ||
| expect(out).not.toMatch(/bypasspermissionson/); | ||
| expect(out).not.toMatch(/pasteagaintoexpand/); | ||
| }); | ||
|
|
||
| it('strips thinking-status fragments without ellipsis anchors', () => { | ||
| const input = [ | ||
| 'meaningful: round 3 codex-player guess=19 feedback=correct', | ||
| 'thinking with high effort', | ||
| '↓ 13 tokens · thinking with high effort', | ||
| 'Crunched for 32s', | ||
| 'Sautéed for 4s', | ||
| 'Gitifying…55', | ||
| ].join('\n'); | ||
| const out = scrub(input); | ||
| expect(out).toContain('feedback=correct'); | ||
| expect(out).not.toMatch(/thinking with high effort/); | ||
| expect(out).not.toMatch(/Crunched for/); | ||
| expect(out).not.toMatch(/Gitifying/); | ||
| }); | ||
|
|
||
| it('preserves real content and OWNER_DECISION signals', () => { | ||
| const input = [ | ||
| 'Read 1 file, calling relaycast 2 times', | ||
| 'Transcript verification reports TRANSCRIPT_OK with all 6 lines well-formed.', | ||
| 'OWNER_DECISION: COMPLETE', | ||
| 'REASON: All 6 turns executed, history.log has 6 lines.', | ||
| 'STEP_COMPLETE: repair-transcript', | ||
| ].join('\n'); | ||
| const out = scrub(input); | ||
| expect(out).toContain('TRANSCRIPT_OK'); | ||
| expect(out).toContain('OWNER_DECISION: COMPLETE'); | ||
| expect(out).toContain('STEP_COMPLETE: repair-transcript'); | ||
| expect(out).toContain('All 6 turns executed'); | ||
| }); | ||
|
|
||
| it('does not strip lines that merely mention model names in prose', () => { | ||
| // Guard against the new claudeFooterRe (which looks for `Opus|Sonnet|Haiku <num> | ||
| // (...context...) ctx:N%`) being too eager and removing prose that | ||
| // mentions a model name. | ||
| const input = [ | ||
| 'Compared output from Opus 4.7 against Sonnet 4.6 — both passed.', | ||
| 'We chose Haiku 4.5 for its latency profile.', | ||
| ].join('\n'); | ||
| const out = scrub(input); | ||
| expect(out).toContain('Opus 4.7 against Sonnet 4.6'); | ||
| expect(out).toContain('Haiku 4.5 for its latency profile'); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Stale state check looks for
state.jsonbut persist mode createsstate-{name}.jsonThe new stale-state detection checks for
{cwd}/.agent-relay/state.json(init.rs:44), butensure_runtime_pathsincrates/broker/src/runtime/paths.rs:140,176,187always createsstate-{safe_name}.json(e.g.,state-my-project.json) in persist mode. The only code that creates a barestate.jsonisensure_ephemeral_paths(paths.rs:64), but that writes to a temp directory, not.agent-relay/. As a result, this stale-state warning will never fire for any persist-mode run, silently defeating the intent of the check.Filename used in persist mode vs stale check
Persist mode (paths.rs:187):
Stale check (init.rs:44):
Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — fixed in e2ceccf.
ensure_runtime_pathswritesstate-{safe_name}.json(not barestate.json), so my original check would never have fired. Replaced the single-name check with a glob of.agent-relay/state-*.jsonso it catches state files from any broker name, and the warning now lists every match.