Skip to content

ci: drop destructive npm self-upgrade in publish workflow #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
willwashburn merged 1 commit into from
Jul 9, 2026
Merged

ci: drop destructive npm self-upgrade in publish workflow #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/workflows/publish-npm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,9 +214,6 @@ jobs:
name: build-output
path: .

- name: Update npm for OIDC support
run: npm install -g npm@latest

- name: Dry run check
if: github.event.inputs.dry_run == 'true'
Comment on lines 217 to 218

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use an npm CLI new enough for trusted publishing

In this workflow I found no NODE_AUTH_TOKEN/NPM_TOKEN, so the real publish paths rely on npm trusted publishing/OIDC; npm's trusted-publishing docs require npm CLI 11.5.1 or later, while the pinned Node 22.22.3 release notes show it bundles npm 10.9.8. Removing this upgrade from both publish jobs leaves npm publish running with a CLI that cannot perform the OIDC token exchange, so non-dry-run publishes will fail authentication even though id-token: write is present; the dry-run path does not exercise that path.

Useful? React with 👍 / 👎.

working-directory: packages/${{ matrix.package }}
Expand Down Expand Up @@ -253,9 +250,6 @@ jobs:
name: build-output
path: .

- name: Update npm for OIDC support
run: npm install -g npm@latest

- name: Dry run check
if: github.event.inputs.dry_run == 'true'
working-directory: packages/${{ github.event.inputs.package }}
Expand Down
Loading