Productize Relayfile cloud mount flow#71
Productize Relayfile cloud mount flow#71khaliqgant wants to merge 2 commits intocodex/relayfile-guided-cloud-setupfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfbedc593f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if err != nil { | ||
| return err | ||
| } | ||
| if err := process.Signal(syscall.SIGTERM); err != nil { |
There was a problem hiding this comment.
runStop always sends syscall.SIGTERM, but on Windows os.Process.Signal only supports os.Kill, so this path returns an error and background mounts cannot be stopped there. This commit added Windows-specific daemon startup support (daemon_windows.go), so relayfile stop becoming nonfunctional on Windows is a user-visible regression for that environment.
Useful? React with 👍 / 👎.
| switch provider { | ||
| case "slack-sage": | ||
| return "slack" | ||
| default: | ||
| return provider |
There was a problem hiding this comment.
providerRootDir only special-cases slack-sage, but fallbackIntegrationCatalog also includes slack-my-senior-dev with VFSRoot: /slack-msd. With the current mapping, status/progress probes and disconnect cleanup target /<provider-id> instead of the actual mounted root for that provider, so these flows operate on the wrong directory for that integration.
Useful? React with 👍 / 👎.
1 participant
Summary
Stack
codex/relayfile-guided-cloud-setup) because this builds on the guided setup entrypoint.Tests
go test ./...npm run typecheckdocs/evidence/productized-cloud-mount-final-evidence.mdHygiene
.trajectoriesindex/untracked trajectory noise unstaged.