Skip to content

add trail view workflows#20

Merged
khaliqgant merged 91 commits intomainfrom
trail-viewer
Apr 13, 2026
Merged

add trail view workflows#20
khaliqgant merged 91 commits intomainfrom
trail-viewer

Conversation

@khaliqgant
Copy link
Copy Markdown
Member

@khaliqgant khaliqgant commented Apr 7, 2026

We should have a trajectory reader app / agent powered discusser


Open with Devin

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 9 additional findings in Devin Review.

Open in Devin Review

workflows/96.ts Outdated
Comment on lines +147 to +160
.step("impl-spotlight", {
agent: "impl-1",
dependsOn: ["plan"],
task: `Create trail-viewer/Sources/Services/SpotlightRegistration.swift from this spec:

{{steps.read-spec.output}}

Extract the SpotlightRegistration.swift code and write it to disk.
IMPORTANT: Write the file to disk. Do NOT output to stdout. Only create this one file.`,
verification: {
type: "file_exists",
value: "trail-viewer/Sources/Services/SpotlightRegistration.swift",
},
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Missing read-spec step in workflow 96 causes unresolved {{steps.read-spec.output}} template

The impl-spotlight step (line 152) and impl-package-update step (line 167) both reference {{steps.read-spec.output}}, but no step named read-spec is defined in this workflow. The workflow defines steps: read-package, plan, impl-spotlight, impl-package-update, verify, commit — no read-spec. Every other workflow in the codebase follows the pattern of having a deterministic read-spec step between plan and the implementation steps (e.g., workflows/01.ts:46) that does cat .relay/specs/XX-name.md with captureOutput: true. Without this step, the implementer agents receive unresolved template variables instead of the planned spec, causing the implementation steps to fail or produce nonsensical output.

Prompt for agents
In workflows/96.ts, a `read-spec` deterministic step is missing between the `plan` step and the two implementation steps (`impl-spotlight` and `impl-package-update`). This step should read the spec file written by the planner agent.

Add a new step after the `plan` step (after line 145, before the `impl-spotlight` step at line 147):

  .step("read-spec", {
    type: "deterministic",
    dependsOn: ["plan"],
    command: "cat .relay/specs/96-spotlight.md",
    captureOutput: true,
  })

Then update both implementation steps to depend on "read-spec" instead of "plan":
- `impl-spotlight` at line 149: change dependsOn from ["plan"] to ["read-spec"]
- `impl-package-update` at line 163: change dependsOn from ["plan"] to ["read-spec"]

This matches the pattern used by all other workflows in the codebase (e.g., workflows/01.ts:46-51, workflows/35.ts:139-144).
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

workflows/97.ts Outdated
Comment on lines +141 to +156
.step("impl-quicklook-gen", {
agent: "impl-swift",
dependsOn: ["plan"],
task: `Create 2 Swift files from this spec:

{{steps.read-spec.output}}

1. trail-viewer/Sources/Services/QuickLookGenerator.swift
2. trail-viewer/Sources/Views/TrajectoryPreviewCard.swift

Write BOTH files to disk. Do NOT output to stdout.`,
verification: {
type: "file_exists",
value: "trail-viewer/Sources/Services/QuickLookGenerator.swift",
},
})
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Missing read-spec step in workflow 97 causes unresolved {{steps.read-spec.output}} template

The impl-quicklook-gen step (line 146) and impl-preview-gen step (line 164) both reference {{steps.read-spec.output}}, but no step named read-spec is defined in this workflow. The workflow defines steps: plan, impl-quicklook-gen, impl-preview-gen, verify, commit — no read-spec. Without this step, the implementer agents receive unresolved template variables instead of the planned spec content, causing the implementation steps to fail or produce nonsensical output.

Prompt for agents
In workflows/97.ts, a `read-spec` deterministic step is missing between the `plan` step and the two implementation steps (`impl-quicklook-gen` and `impl-preview-gen`). This step should read the spec file written by the planner agent.

Add a new step after the `plan` step (after line 138, before the `impl-quicklook-gen` step at line 141):

  .step("read-spec", {
    type: "deterministic",
    dependsOn: ["plan"],
    command: "cat .relay/specs/97-quicklook.md",
    captureOutput: true,
  })

Then update both implementation steps to depend on "read-spec" instead of "plan":
- `impl-quicklook-gen` at line 143: change dependsOn from ["plan"] to ["read-spec"]
- `impl-preview-gen` at line 161: change dependsOn from ["plan"] to ["read-spec"]

This matches the pattern used by all other workflows in the codebase (e.g., workflows/01.ts:46-51, workflows/35.ts:139-144).
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@khaliqgant khaliqgant merged commit 9afb101 into main Apr 13, 2026
6 checks passed
@khaliqgant khaliqgant deleted the trail-viewer branch April 13, 2026 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant