Conversation
workflows/96.ts
Outdated
| .step("impl-spotlight", { | ||
| agent: "impl-1", | ||
| dependsOn: ["plan"], | ||
| task: `Create trail-viewer/Sources/Services/SpotlightRegistration.swift from this spec: | ||
|
|
||
| {{steps.read-spec.output}} | ||
|
|
||
| Extract the SpotlightRegistration.swift code and write it to disk. | ||
| IMPORTANT: Write the file to disk. Do NOT output to stdout. Only create this one file.`, | ||
| verification: { | ||
| type: "file_exists", | ||
| value: "trail-viewer/Sources/Services/SpotlightRegistration.swift", | ||
| }, | ||
| }) |
There was a problem hiding this comment.
🔴 Missing read-spec step in workflow 96 causes unresolved {{steps.read-spec.output}} template
The impl-spotlight step (line 152) and impl-package-update step (line 167) both reference {{steps.read-spec.output}}, but no step named read-spec is defined in this workflow. The workflow defines steps: read-package, plan, impl-spotlight, impl-package-update, verify, commit — no read-spec. Every other workflow in the codebase follows the pattern of having a deterministic read-spec step between plan and the implementation steps (e.g., workflows/01.ts:46) that does cat .relay/specs/XX-name.md with captureOutput: true. Without this step, the implementer agents receive unresolved template variables instead of the planned spec, causing the implementation steps to fail or produce nonsensical output.
Prompt for agents
In workflows/96.ts, a `read-spec` deterministic step is missing between the `plan` step and the two implementation steps (`impl-spotlight` and `impl-package-update`). This step should read the spec file written by the planner agent.
Add a new step after the `plan` step (after line 145, before the `impl-spotlight` step at line 147):
.step("read-spec", {
type: "deterministic",
dependsOn: ["plan"],
command: "cat .relay/specs/96-spotlight.md",
captureOutput: true,
})
Then update both implementation steps to depend on "read-spec" instead of "plan":
- `impl-spotlight` at line 149: change dependsOn from ["plan"] to ["read-spec"]
- `impl-package-update` at line 163: change dependsOn from ["plan"] to ["read-spec"]
This matches the pattern used by all other workflows in the codebase (e.g., workflows/01.ts:46-51, workflows/35.ts:139-144).
Was this helpful? React with 👍 or 👎 to provide feedback.
workflows/97.ts
Outdated
| .step("impl-quicklook-gen", { | ||
| agent: "impl-swift", | ||
| dependsOn: ["plan"], | ||
| task: `Create 2 Swift files from this spec: | ||
|
|
||
| {{steps.read-spec.output}} | ||
|
|
||
| 1. trail-viewer/Sources/Services/QuickLookGenerator.swift | ||
| 2. trail-viewer/Sources/Views/TrajectoryPreviewCard.swift | ||
|
|
||
| Write BOTH files to disk. Do NOT output to stdout.`, | ||
| verification: { | ||
| type: "file_exists", | ||
| value: "trail-viewer/Sources/Services/QuickLookGenerator.swift", | ||
| }, | ||
| }) |
There was a problem hiding this comment.
🔴 Missing read-spec step in workflow 97 causes unresolved {{steps.read-spec.output}} template
The impl-quicklook-gen step (line 146) and impl-preview-gen step (line 164) both reference {{steps.read-spec.output}}, but no step named read-spec is defined in this workflow. The workflow defines steps: plan, impl-quicklook-gen, impl-preview-gen, verify, commit — no read-spec. Without this step, the implementer agents receive unresolved template variables instead of the planned spec content, causing the implementation steps to fail or produce nonsensical output.
Prompt for agents
In workflows/97.ts, a `read-spec` deterministic step is missing between the `plan` step and the two implementation steps (`impl-quicklook-gen` and `impl-preview-gen`). This step should read the spec file written by the planner agent.
Add a new step after the `plan` step (after line 138, before the `impl-quicklook-gen` step at line 141):
.step("read-spec", {
type: "deterministic",
dependsOn: ["plan"],
command: "cat .relay/specs/97-quicklook.md",
captureOutput: true,
})
Then update both implementation steps to depend on "read-spec" instead of "plan":
- `impl-quicklook-gen` at line 143: change dependsOn from ["plan"] to ["read-spec"]
- `impl-preview-gen` at line 161: change dependsOn from ["plan"] to ["read-spec"]
This matches the pattern used by all other workflows in the codebase (e.g., workflows/01.ts:46-51, workflows/35.ts:139-144).
Was this helpful? React with 👍 or 👎 to provide feedback.
…ow search match highlighting
…ine with copy and save
… line-numbered content
Uh oh!
There was an error while loading. Please reload this page.