Skip to content

Commit 6345a0a

Browse files
committed
fix(frontend): enforce node 24 before install
1 parent f44345a commit 6345a0a

10 files changed

Lines changed: 16 additions & 39 deletions

File tree

.github/workflows/desktop-testing.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ jobs:
4343
- uses: actions/checkout@v4
4444
- uses: actions/setup-node@v4
4545
with:
46-
node-version: 20
46+
node-version: 24
4747
cache: npm
4848
cache-dependency-path: frontend/package-lock.json
4949
# The daemon is compiled by build-daemon.mjs during premake, so the Go

.github/workflows/frontend-nightly.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
fetch-depth: 0 # need tags + history for the no-new-commits check
2323
- uses: actions/setup-node@v4
2424
with:
25-
node-version: 20
25+
node-version: 24
2626
- id: check
2727
shell: bash
2828
run: |
@@ -60,7 +60,7 @@ jobs:
6060
- uses: actions/checkout@v4
6161
- uses: actions/setup-node@v4
6262
with:
63-
node-version: 20
63+
node-version: 24
6464
cache: npm
6565
cache-dependency-path: frontend/package-lock.json
6666
- uses: actions/setup-go@v5
@@ -121,7 +121,7 @@ jobs:
121121
- uses: actions/checkout@v4
122122
- uses: actions/setup-node@v4
123123
with:
124-
node-version: 20
124+
node-version: 24
125125
cache: npm
126126
cache-dependency-path: frontend/package-lock.json
127127
- uses: actions/setup-go@v5
@@ -192,7 +192,7 @@ jobs:
192192
- uses: actions/checkout@v4
193193
- uses: actions/setup-node@v4
194194
with:
195-
node-version: 20
195+
node-version: 24
196196
cache: npm
197197
cache-dependency-path: frontend/package-lock.json
198198
- run: npm ci

.github/workflows/frontend-release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
- uses: actions/checkout@v4
5656
- uses: actions/setup-node@v4
5757
with:
58-
node-version: 20
58+
node-version: 24
5959
cache: npm
6060
cache-dependency-path: frontend/package-lock.json
6161
# The daemon is compiled by build-daemon.mjs during prepackage/premake, so
@@ -183,7 +183,7 @@ jobs:
183183
- uses: actions/checkout@v4
184184
- uses: actions/setup-node@v4
185185
with:
186-
node-version: 20
186+
node-version: 24
187187
cache: npm
188188
cache-dependency-path: frontend/package-lock.json
189189
- uses: actions/setup-go@v5
@@ -248,7 +248,7 @@ jobs:
248248
- uses: actions/checkout@v4
249249
- uses: actions/setup-node@v4
250250
with:
251-
node-version: 20
251+
node-version: 24
252252
cache: npm
253253
cache-dependency-path: frontend/package-lock.json
254254
# feed.mjs imports app-builder-lib's blockmap generator, so deps are needed.

.github/workflows/frontend.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131

3232
- uses: actions/setup-node@v4
3333
with:
34-
node-version: 20
34+
node-version: 24
3535
cache: npm
3636
cache-dependency-path: frontend/package-lock.json
3737

.github/workflows/testing-build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
- uses: actions/checkout@v4
4949
- uses: actions/setup-node@v4
5050
with:
51-
node-version: 20
51+
node-version: 24
5252
cache: npm
5353
cache-dependency-path: frontend/package-lock.json
5454
- uses: actions/setup-go@v5

README.md

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,9 @@ Works with 23+ CLI-based coding agents including Claude Code, OpenAI Codex, Curs
8080
| Git | Any | Latest |
8181
| pnpm | Any | Latest |
8282

83-
The Electron frontend is currently developed and packaged on Node 20.x. Run
84-
`nvm use 20 || nvm install 20` before installing `frontend/` dependencies; its
85-
preinstall check rejects unsupported runtimes before they can leave Electron
86-
partially installed.
83+
The Electron frontend is currently developed and packaged on Node 24.x. Run
84+
`nvm use 24 || nvm install 24` before installing `frontend/` dependencies; its
85+
strict engine check rejects unsupported runtimes before dependency installation.
8786

8887
**Optional:**
8988

frontend/.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
11
node-linker=hoisted
22
minimum-release-age=0
3+
engine-strict=true

frontend/.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
20
1+
24

frontend/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"author": "Agent Orchestrator",
88
"license": "MIT",
99
"engines": {
10-
"node": "20.x"
10+
"node": "24.x"
1111
},
1212
"homepage": "https://github.com/aoagents/agent-orchestrator",
1313
"main": ".vite/build/main.js",
@@ -16,7 +16,6 @@
1616
"url": "https://github.com/aoagents/agent-orchestrator"
1717
},
1818
"scripts": {
19-
"preinstall": "node ./scripts/check-node-version.mjs",
2019
"build:daemon": "node ./scripts/build-daemon.mjs",
2120
"dev": "electron-forge start",
2221
"dev:web": "VITE_NO_ELECTRON=1 vite --config vite.renderer.config.ts",

frontend/scripts/check-node-version.mjs

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)