fix: show latest reviewer verdict after PR updates#2303
Draft
neversettle17-101 wants to merge 2 commits into
Draft
fix: show latest reviewer verdict after PR updates#2303neversettle17-101 wants to merge 2 commits into
neversettle17-101 wants to merge 2 commits into
Conversation
24dace5 to
327125d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2300.
Before
changes_requestedonsha-oldand the worker pushedsha-new, the planner found no run forsha-new.needs_review, but had nolatestRunattached for display.Not run, even though the latest actual review verdict waschanges_requestedorapproved.Run reviewbutton was available, which was correct.After
needs_reviewwhen the head SHA changes, so the button stays available.latestRun, even if that run was for a previous SHA.latestRun.verdictwhen choosing the visible label.changes_requestedonsha-oldand a push tosha-new, the row and top badge still showChanges requested.Run reviewto send the next review request forsha-new.Reviewer trigger behavior
Notify/SendMessage.Tests
npm run lintnpm run frontend:typecheckcd backend && go test ./internal/review ./internal/httpd/...