Fix restored terminal reconnect#2313
Open
codebanditssss wants to merge 1 commit into
Open
Conversation
- Reopen terminal mux after restored sessions become live - Cover restore with unchanged terminal handles
harshitsinghbhandari
left a comment
harshitsinghbhandari
left a comment
Collaborator
There was a problem hiding this comment.
Reconnect should only fire when the session actually comes back to life, not on every session update, otherwise a permanently-broken pane keeps retrying on each tick with no backoff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Test: