Commit 6821d0f
GanJiaKouN16
fix: show correct breadcrumb label for SDK evaluations
The breadcrumb always showed 'Auto Evals' for SDK evaluations because:
1. test.tsx normalized type='custom' to 'auto' before passing to
EvalRunPreviewPage, losing the SDK type information
2. Page.tsx typeMap had no 'custom' entry
3. buildBreadcrumbs.ts hardcoded 'auto evaluation' as fallback label
Fix:
- Remove the custom→auto normalization in test.tsx
- Add 'custom' → 'SDK Evals' entry to Page.tsx typeMap (matches the
tab label in EvaluationsView.tsx)
- Change buildBreadcrumbs.ts fallback from 'auto evaluation' to
'Evaluations'
Closes #45491 parent 7b29544 commit 6821d0f
3 files changed
Lines changed: 3 additions & 3 deletions
File tree
- web/oss/src
- components/EvalRunDetails
- components
- lib/helpers
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| 51 | + | |
51 | 52 | | |
52 | 53 | | |
53 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
13 | 12 | | |
14 | 13 | | |
15 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
0 commit comments