Commit 8b9a5b0
committed
fix(frontend): forward className in Editor noProvider mode and clean up workarounds
The shared Editor dropped `className`/`editorClassName` when rendered with
`noProvider` (it only applied the class on the EditorProvider path). Forward
it to EditorInner and apply it to the editor container in that mode too.
With the prop working, clean up the call sites that relied on the drop:
- ChatMessageEditor: move the message text/placeholder alignment from the
globals.css workaround to editorClassName; globals.css now only carries the
antd role-button override that cannot go through the prop.
- VariableControlAdapter: stop forwarding the generation-row container class as
editorClassName (it is a container/cell-strip style that would strip the
editor's border and gutter); it stays on the container only.
- GenerationComparisonChatOutput: pad the editor body via editorClassName
instead of the [&_.agenta-editor-wrapper] container hack.1 parent 5e2ccc6 commit 8b9a5b0
5 files changed
Lines changed: 45 additions & 30 deletions
File tree
- web
- oss/src/styles
- packages
- agenta-playground-ui/src/components
- ExecutionItemComparisonView/GenerationComparisonChatOutput
- adapters
- agenta-ui/src
- ChatMessage/components
- Editor
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
206 | 206 | | |
207 | 207 | | |
208 | 208 | | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
223 | 215 | | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
| 216 | + | |
231 | 217 | | |
232 | 218 | | |
233 | 219 | | |
| |||
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
154 | | - | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
155 | 158 | | |
156 | 159 | | |
157 | 160 | | |
| |||
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
549 | 549 | | |
550 | 550 | | |
551 | 551 | | |
552 | | - | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
553 | 560 | | |
554 | 561 | | |
555 | 562 | | |
| |||
Lines changed: 12 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
210 | 210 | | |
211 | 211 | | |
212 | 212 | | |
213 | | - | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
214 | 223 | | |
215 | 224 | | |
216 | 225 | | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
| 226 | + | |
| 227 | + | |
221 | 228 | | |
222 | 229 | | |
223 | 230 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
| 176 | + | |
176 | 177 | | |
177 | 178 | | |
178 | 179 | | |
| |||
755 | 756 | | |
756 | 757 | | |
757 | 758 | | |
758 | | - | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
759 | 770 | | |
760 | 771 | | |
761 | 772 | | |
| |||
1119 | 1130 | | |
1120 | 1131 | | |
1121 | 1132 | | |
| 1133 | + | |
1122 | 1134 | | |
1123 | 1135 | | |
1124 | 1136 | | |
| |||
0 commit comments