fix(playground): clean stale row on app swap + drop diagnostic logs (#4525)

Two follow-ups now that the row-reconciliation fix is verified working:

1. Clean-on-swap: the evaluator playground selects an app via
   changePrimaryNode + connectDownstreamNode (ConfigureEvaluator), not a
   setEntityIds positional swap — so the previously-wired swap-time prune
   never fired there. Add playgroundController.actions.reconcileRowsToPrimary
   and call it from connectAppToEvaluatorAtom AFTER connectDownstreamNode, so
   the shared testcase row is cleaned the instant the app changes (not only at
   run time). Running after the downstream connect means the evaluator's
   referenced columns (correct_answer_key → ground_truth, etc.) are protected
   from the strict app-contract clean.

   pruneTestcaseRowsForEntity now:
   - collects downstream-evaluator protected columns,
   - returns a status ('acted' | 'noop' | 'unresolved').

   reconcileRowsToPrimary handles the hydration race: if the new primary's
   inputPorts aren't resolved yet AND the entity isn't loaded, it subscribes
   to inputPorts and retries once, then unsubscribes. If the entity is loaded
   but genuinely has no variables, it doesn't subscribe (no dangling sub). The
   run-time reconciliation in webWorkerIntegration remains the backstop.

2. Remove diagnostic logs added while tracing the bug:
   [executionRunner.filter], [webWorker.reconcile],
   [playgroundController.prune]. The reconcile + writeback logic stays; only
   the console.warn telemetry is dropped.

Author: ardaerzin

web/oss/src/components/Evaluators/components/ConfigureEvaluator/atoms.ts

@@ -188,6 +188,15 @@ export const connectAppToEvaluatorAtom = atom(
             },
         })
 
+        // Clean the shared testcase row against the newly-selected app's input
+        // contract so stale keys from a previously-selected app (e.g. chat
+        // `messages`/`context` after swapping a chat app for a completion app)
+        // are dropped immediately — not only at run time (#4525 / AGE-3793).
+        // Runs AFTER connectDownstreamNode so the evaluator is in the graph and
+        // its referenced columns (correct_answer_key → ground_truth, etc.) are
+        // protected from the strict app-contract clean.
+        set(playgroundController.actions.reconcileRowsToPrimary)
+
         // Persist only after both graph mutations succeeded. The picker
         // display label is derived from the depth-0 node's `label` via
         // `selectedAppLabelAtom`, so no extra write needed here.

web/packages/agenta-playground/src/state/controllers/playgroundController.ts

@@ -83,7 +83,11 @@ import {
     newTestcaseDataHashAtom,
 } from "../execution/selectors"
 import {pruneDanglingConnections} from "../helpers/connectionGraph"
-import {reconcileRowDataForEntity, resolveEntityInputContract} from "../helpers/entityInputContract"
+import {
+    collectDownstreamReferencedColumns,
+    reconcileRowDataForEntity,
+    resolveEntityInputContract,
+} from "../helpers/entityInputContract"
 import {extractAndLoadChatMessagesAtom} from "../helpers/extractAndLoadChatMessages"
 import {normalizeTestcaseRowsForLoad} from "../helpers/testcaseRowNormalization"
 import type {EntitySelection, PlaygroundNode, RunnableType} from "../types"
@@ -2133,88 +2137,113 @@ function relinkLoadableSessions(
     }
 }
 
+type PruneStatus = "acted" | "noop" | "unresolved"
+
 /**
- * Reconcile every testcase row against the new primary entity's input
- * contract.
+ * Reconcile every testcase row against the given entity's input contract.
  *
  * Why this exists: the testcase row store (`testcaseMolecule`) is shared
  * across loadables. When the user swaps the primary app in the LLM-as-a-
- * judge playground (anchor swap in `setEntityIdsAtom`), the row data keeps
- * every key the *previous* primary populated — chat `messages`, completion
- * template variables that the new app doesn't declare, etc. Without
- * reconciliation, those stale keys leak into the new app's request body
- * via the downstream "spread all keys" fallbacks.
- *
- * Handling at the row layer (here) makes the UI immediately reflect the new
- * app's variables and is the primary fix; execution-time reconciliation in
- * `executionRunner.ts` is only a hydration-window safety net.
+ * judge playground, the row data keeps every key the *previous* primary
+ * populated — chat `messages`, completion template variables that the new
+ * app doesn't declare, etc. Without reconciliation, those stale keys leak
+ * into the new app's request body and the downstream evaluator's envelope.
  *
  * Allow-list source is `inputPorts` (via `resolveEntityInputContract`), NOT
  * `inputSchema.properties` — completion apps surface their variables as
  * prompt template placeholders through `inputPorts` and have an EMPTY static
  * input schema, so schema-based filtering keeps everything. Policy:
- *   - App with a resolved contract → strict: keep only declared keys.
+ *   - App with a resolved contract → strict: keep only declared (or
+ *     downstream-evaluator-protected) keys.
  *   - Evaluator → chat-transport only: evaluators spread extra testcase
  *     columns, so we never strict-filter them.
- *   - Unresolved contract (ports mid-hydration) → skip; the execution-time
- *     reconciliation catches it. A console.warn is emitted so we can see
- *     when the hydration window is hit.
+ *   - Unresolved contract (ports mid-hydration) → no-op; returns
+ *     `"unresolved"` so the caller can retry once the contract resolves. The
+ *     run-time reconciliation in `webWorkerIntegration` is the backstop.
+ *
+ * Columns referenced by downstream evaluator `<input>_key` settings (e.g.
+ * `correct_answer_key → ground_truth`) are protected so a strict clean
+ * against the app contract doesn't drop intentional evaluation inputs.
  *
  * Mutations go through `testcaseMolecule.actions.batchUpdate` setting stale
  * keys to `undefined`, which the store's update reducer interprets as a
  * delete. Drafts are created as needed (one per affected row).
  */
-function pruneTestcaseRowsForEntity(get: Getter, set: Setter, entityId: string) {
+function pruneTestcaseRowsForEntity(get: Getter, set: Setter, entityId: string): PruneStatus {
     const contract = resolveEntityInputContract(get, entityId)
 
     // Unresolved, non-evaluator contract → we can't strict-filter safely yet.
     // The evaluator path is always "resolved enough" (chat-transport strip
     // works without a variable list), so only bail for non-evaluator apps.
     if (!contract.isEvaluator && !contract.resolved) {
-        console.warn("[playgroundController.prune] contract-not-resolved on swap", {
-            entityId,
-            // Without resolved inputPorts we can't decide what to drop. The
-            // execution-time reconciliation catches the leak window for now.
-        })
-        return
+        return "unresolved"
     }
 
     const displayRowIds = get(testcaseMolecule.atoms.displayRowIds)
-    if (!Array.isArray(displayRowIds) || displayRowIds.length === 0) return
+    if (!Array.isArray(displayRowIds) || displayRowIds.length === 0) return "noop"
+
+    const protectedColumns = collectDownstreamReferencedColumns(get, get(playgroundNodesAtom))
 
     const updates: {id: string; updates: {data: Record<string, unknown>}}[] = []
-    const droppedPerRow: Record<string, string[]> = {}
-    let strategyUsed: string | null = null
 
     for (const rowId of displayRowIds) {
         const row = get(testcaseMolecule.data(rowId))
         const data = (row as {data?: Record<string, unknown>} | null)?.data
         if (!data || typeof data !== "object") continue
 
-        const {dropped, strategy} = reconcileRowDataForEntity(get, entityId, data)
+        const {dropped} = reconcileRowDataForEntity(get, entityId, data, {
+            protectedKeys: protectedColumns,
+        })
         if (dropped.length === 0) continue
-        strategyUsed = strategy
 
         const undefinedData: Record<string, unknown> = {}
         for (const key of dropped) {
             undefinedData[key] = undefined
         }
         updates.push({id: rowId, updates: {data: undefinedData}})
-        droppedPerRow[rowId] = dropped
     }
 
-    if (updates.length === 0) return
-
-    console.warn("[playgroundController.prune] dropped stale keys after primary swap", {
-        entityId,
-        rowsAffected: updates.length,
-        strategy: strategyUsed,
-        droppedPerRow,
-    })
+    if (updates.length === 0) return "noop"
 
     set(testcaseMolecule.actions.batchUpdate, updates)
+    return "acted"
 }
 
+/**
+ * Reconcile all testcase rows against the CURRENT primary (depth-0) entity's
+ * input contract, on demand — call this right after a primary swap so the
+ * shared row is cleaned the instant the app changes, without waiting for a
+ * run. The run-time reconciliation in `webWorkerIntegration` is the backstop.
+ *
+ * Hydration handling: the new primary's input ports may not be resolved at
+ * call time (the workflow is still loading). When the prune reports
+ * `"unresolved"` AND the entity isn't loaded yet, we subscribe to its
+ * `inputPorts` and retry once they resolve, then unsubscribe. If the entity
+ * is already loaded but has no resolvable variables, there's nothing to wait
+ * for, so we don't subscribe (avoids a dangling subscription).
+ */
+const reconcileRowsToPrimaryAtom = atom(null, (get, set) => {
+    const nodes = get(playgroundNodesAtom)
+    const primary = nodes.find((node) => node.depth === 0)
+    if (!primary) return
+    const entityId = primary.entityId
+
+    const status = pruneTestcaseRowsForEntity(get, set, entityId)
+    if (status !== "unresolved") return
+
+    // Unresolved: either the workflow is still loading, or it's a genuinely
+    // no-variable app. Only wait if it hasn't loaded yet.
+    const entityLoaded = get(workflowMolecule.selectors.data(entityId)) != null
+    if (entityLoaded) return
+
+    const store = getDefaultStore()
+    const unsub = store.sub(workflowMolecule.selectors.inputPorts(entityId), () => {
+        const retryStatus = pruneTestcaseRowsForEntity(store.get, store.set, entityId)
+        const nowLoaded = store.get(workflowMolecule.selectors.data(entityId)) != null
+        if (retryStatus !== "unresolved" || nowLoaded) unsub()
+    })
+})
+
 /**
  * Switch one entity for another in the displayed selection.
  * Handles both single and comparison mode. The loadable-scoped re-link
@@ -2336,6 +2365,13 @@ export const playgroundController = {
         /** Change the primary node */
         changePrimaryNode: changePrimaryNodeAtom,
 
+        /**
+         * Reconcile all testcase rows against the current primary entity's
+         * input contract. Call after a primary swap to clean stale keys from a
+         * previous app off the shared row immediately (#4525 / AGE-3793).
+         */
+        reconcileRowsToPrimary: reconcileRowsToPrimaryAtom,
+
         /** Disconnect from testset and reset to local mode */
         disconnectAndResetToLocal: disconnectAndResetToLocalAtom,
 

web/packages/agenta-playground/src/state/execution/executionRunner.ts

@@ -261,15 +261,7 @@ function reconcileEntityInputData(
     data: Record<string, unknown>,
     entityId: string,
 ): Record<string, unknown> {
-    const {data: next, dropped, strategy} = reconcileRowDataForEntity(get, entityId, data)
-    if (dropped.length > 0) {
-        console.warn("[executionRunner.filter] reconciled stale row keys", {
-            entityId,
-            strategy,
-            dropped,
-        })
-    }
-    return next
+    return reconcileRowDataForEntity(get, entityId, data).data
 }
 
 function createConcurrencyLimiter(concurrency: number) {

web/packages/agenta-playground/src/state/execution/webWorkerIntegration.ts

@@ -350,13 +350,6 @@ export const triggerExecutionAtom = atom(
             // Persist the cleaned row (deletes the dropped keys via the
             // testcase store's undefined-means-delete semantics).
             set(loadableController.actions.updateRow, loadableId, logicalRowId, undefinedPatch)
-            console.warn("[webWorker.reconcile] cleaned stale row keys before run", {
-                rootEntityId,
-                rowId: logicalRowId,
-                strategy: reconciledRow.strategy,
-                dropped: reconciledRow.dropped,
-                protectedColumns: Array.from(protectedColumns),
-            })
         }
 
         // In comparison mode, filter nodes to only include the effective variant's