-
Notifications
You must be signed in to change notification settings - Fork 515
[ci] Clean up workflows #3954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Clean up workflows #3954
Changes from all commits
bf51506
95a390b
4a13f5d
ef4a3f8
a74d2b0
2a9822d
3b2c38f
cc78ea8
6a7ed4a
5117728
3e38d79
da8f118
e0de468
533c707
f3f92c6
98a59e0
bba6a78
ce38e29
0dc898e
35194ba
c9df95a
f1d39d1
8addfac
e6aa118
c8fabcb
135d221
18eb6aa
5511abf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: 00 ---------- Releases | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| release: | ||
| name: Releases | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Releases | ||
| run: echo "releases" | ||
This file was deleted.
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: 10 ---------- Checks | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
|
|
||
| permissions: {} | ||
|
|
||
| jobs: | ||
| check: | ||
| name: Checks | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checks | ||
| run: echo "checks" | ||
|
|
||
This file was deleted.
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,96 @@ | ||||||||||
| name: 11 - check code styling | ||||||||||
|
|
||||||||||
| permissions: | ||||||||||
| contents: read | ||||||||||
|
|
||||||||||
| on: | ||||||||||
| pull_request: | ||||||||||
| paths: | ||||||||||
| - 'api/**' | ||||||||||
| - 'sdk/**' | ||||||||||
| - 'web/**' | ||||||||||
| - '.github/workflows/11-check-code-styling.yml' | ||||||||||
| workflow_dispatch: | ||||||||||
|
|
||||||||||
| jobs: | ||||||||||
| ruff-format: | ||||||||||
| name: Python format | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: Set up Python | ||||||||||
| uses: actions/setup-python@v5 | ||||||||||
| with: | ||||||||||
| python-version: '3.11' | ||||||||||
|
|
||||||||||
| - name: Install Ruff | ||||||||||
| run: pip install ruff==0.14.0 | ||||||||||
|
|
||||||||||
| - name: Run Ruff formatting check | ||||||||||
| run: ruff format --check | ||||||||||
|
|
||||||||||
| ruff-lint: | ||||||||||
| name: Python lint | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: Set up Python | ||||||||||
| uses: actions/setup-python@v5 | ||||||||||
| with: | ||||||||||
| python-version: '3.11' | ||||||||||
|
|
||||||||||
| - name: Install Ruff | ||||||||||
| run: pip install ruff==0.14.0 | ||||||||||
|
|
||||||||||
| - name: Run Ruff linting check | ||||||||||
| run: ruff check | ||||||||||
|
|
||||||||||
| prettier-format: | ||||||||||
| name: TypeScript format | ||||||||||
| runs-on: ubuntu-latest | ||||||||||
| steps: | ||||||||||
| - uses: actions/checkout@v4 | ||||||||||
|
|
||||||||||
| - name: Install pnpm | ||||||||||
| uses: pnpm/action-setup@v4 | ||||||||||
| with: | ||||||||||
| version: 10 | ||||||||||
|
|
||||||||||
| - name: Set up Node.js | ||||||||||
| uses: actions/setup-node@v4 | ||||||||||
| with: | ||||||||||
| node-version: 20 | ||||||||||
| cache: 'pnpm' | ||||||||||
| cache-dependency-path: web/pnpm-lock.yaml | ||||||||||
|
|
||||||||||
| - name: Install dependencies | ||||||||||
| run: cd web && pnpm install --frozen-lockfile | ||||||||||
|
|
||||||||||
| - name: Run Prettier formatting fix | ||||||||||
| run: cd web && pnpm run format-fix | ||||||||||
|
Comment on lines
+71
to
+72
|
||||||||||
| - name: Run Prettier formatting fix | |
| run: cd web && pnpm run format-fix | |
| - name: Run Prettier formatting check | |
| run: cd web && pnpm run format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 CI workflow step name says "fix" instead of "check" for Prettier and ESLint
In .github/workflows/11-check-code-styling.yml, the prettier-format job's step is named "Run Prettier formatting fix" (line 71) and runs pnpm run format-fix (line 72), and the eslint job's step is named "Run ESLint fix" (line 95) and runs pnpm run lint-fix (line 96). A CI check workflow should only check for violations (non-zero exit on failure), not fix them. Running format-fix and lint-fix will auto-correct files and the job will always pass, defeating the purpose of a PR gate check. The deleted workflows (02-check-python-formatting.yml, 04-check-frontend-linting.yml) correctly used ruff format --check and pnpm lint (check-only commands).
Prompt for agents
In .github/workflows/11-check-code-styling.yml, the prettier-format job (lines 71-72) should run a check-only command instead of a fix command. Change the step name to 'Run Prettier formatting check' and the command to 'cd web && pnpm run format-check' (or equivalent check-only script). Similarly, the eslint job (lines 95-96) should run a check-only command. Change the step name to 'Run ESLint check' and the command to 'cd web && pnpm run lint' (or equivalent). Running fix commands in CI will silently auto-correct issues and always succeed, making the check useless as a PR gate.
Was this helpful? React with 👍 or 👎 to provide feedback.
Copilot
AI
Mar 11, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This job runs pnpm run lint-fix (auto-fix) instead of a check-only lint command. That can mask lint issues by fixing them in the runner workspace and still exiting 0, which defeats the purpose of a PR check. Prefer pnpm run lint (or an equivalent non-fixing lint command) so violations cause CI to fail.
| - name: Run ESLint fix | |
| run: cd web && pnpm run lint-fix | |
| - name: Run ESLint lint check | |
| run: cd web && pnpm run lint |
Uh oh!
There was an error while loading. Please reload this page.