Skip to content

docs(agent-workflows): reject-siblings approval policy proposal (Deny/Stop/steer)#5444

Open
ardaerzin wants to merge 1 commit into
feat/sessions-storage-reworkfrom
docs/reject-siblings-proposal
Open

docs(agent-workflows): reject-siblings approval policy proposal (Deny/Stop/steer)#5444
ardaerzin wants to merge 1 commit into
feat/sessions-storage-reworkfrom
docs/reject-siblings-proposal

Conversation

@ardaerzin

Copy link
Copy Markdown
Contributor

Answers the open question in the sessions-takeover handoff (§6): what rejecting one approval card should do to its siblings.

Proposal: keep per-card rejection as the default, don't adopt an inferred cascade, and make scope explicit — Deny (per card) + Stop (turn-level, ≥2 cards) + steer (reject-with-message → model feedback).

Why not an inferred cascade: siblings are real (Pi parks a parallel batch as N cards) and can be heterogeneous — a bash write next to a Gmail send — keyed only by toolCallId, no danger/grouping signal on the wire. The runner can't tell related from unrelated, so "reject → stop all" guesses wrong exactly in the dangerous case.

Feasibility checked: warm Stop is feasible-but-unbuilt — park/resume already ends a turn without disposing the session. v1 Stop = deny-all-via-resume (warm, no runner work); v2 = true cancel (task 5). The one unexercised Claude-ACP path is the acceptance test for v2, not a blocker.

Full reasoning + file:line evidence in the doc. Requesting a ruling on the model before building.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 22, 2026 11:52am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d54ac86-cf37-4466-b1cf-c0d437343693

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/reject-siblings-proposal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation proposal labels Jul 22, 2026

@mmabrouk mmabrouk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ardaerzin lgtm

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Jul 22, 2026
@ardaerzin
ardaerzin changed the base branch from plan/concurrent-approvals to feat/sessions-storage-rework July 22, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer proposal size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants