Add Windows build enhancements and accessibility improvements#3
Add Windows build enhancements and accessibility improvements#3DickHorner wants to merge 6 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This pull request enhances the A5 PII Anonymizer Electron application with Windows build improvements, accessibility features, and code quality updates. The changes include adding code signing preparation, screen reader support, refactored build configuration, and formatting standardization via Prettier.
Key Changes:
- Added accessibility improvements with screen reader labels and ARIA-compliant markup
- Introduced Windows build preparation scripts and afterPack hooks for better packaging
- Upgraded dependencies including Electron (34.2.0 → 39.2.7) and several document processing libraries
- Standardized code formatting across the codebase using Prettier
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| styles.css | Added accessibility classes (sr-only, file-input-hidden, manage-info) and applied Prettier formatting |
| scripts/prepare-canvas-dirs.js | New script to ensure canvas platform directories exist for Windows builds |
| renderer.js | Applied consistent code formatting (spacing, quotes, trailing commas) |
| package.json | Updated dependencies, added format scripts, restructured build configuration with new Windows-specific options |
| main.js | Improved path handling with explicit join and formatting cleanup |
| index.html | Enhanced accessibility with lang attribute, meta tags, sr-only labels for screen readers |
| fileProcessor.js | Changed pdf-parse to use createRequire for compatibility and applied formatting |
| build-scripts/afterPack.cjs | New script to handle post-packaging file copying for the build process |
| all.min.css | Reformatted minified CSS with Prettier (expanded format) |
| README.md | Cleaned up trailing whitespace and improved formatting consistency |
| .prettierignore | New file to exclude specific directories from Prettier formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This pull request introduces several improvements and fixes across the codebase to enhance maintainability, packaging, and user experience. The most significant changes include the addition of a custom after-pack script for Electron builds, improvements to accessibility and HTML structure, updates to dependencies and build scripts, and consistent formatting and logging. Below are the most important changes grouped by theme: Build and Packaging Improvements
Accessibility and HTML/CSS Enhancements
Dependency and Code Modernization
Code Consistency and Logging
Documentation |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Introduce code signing options for the Windows build configuration, enhance accessibility features with screen reader labels, and improve file input handling. Refactor the build configuration and add an afterPack script to streamline the packaging process. Fix bugs in the Windows build script and upgrade Electron to address vulnerabilities while ensuring code formatting adheres to Prettier standards.