Skip to content

Add Windows build enhancements and accessibility improvements#3

Open
DickHorner wants to merge 6 commits into
AgenticA5:mainfrom
DickHorner:main
Open

Add Windows build enhancements and accessibility improvements#3
DickHorner wants to merge 6 commits into
AgenticA5:mainfrom
DickHorner:main

Conversation

@DickHorner
Copy link
Copy Markdown

Introduce code signing options for the Windows build configuration, enhance accessibility features with screen reader labels, and improve file input handling. Refactor the build configuration and add an afterPack script to streamline the packaging process. Fix bugs in the Windows build script and upgrade Electron to address vulnerabilities while ensuring code formatting adheres to Prettier standards.

DickHorner

This comment was marked as outdated.

@DickHorner DickHorner marked this pull request as ready for review December 25, 2025 01:25
Copilot AI review requested due to automatic review settings December 25, 2025 01:25
@DickHorner
Copy link
Copy Markdown
Author

@codex review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request enhances the A5 PII Anonymizer Electron application with Windows build improvements, accessibility features, and code quality updates. The changes include adding code signing preparation, screen reader support, refactored build configuration, and formatting standardization via Prettier.

Key Changes:

  • Added accessibility improvements with screen reader labels and ARIA-compliant markup
  • Introduced Windows build preparation scripts and afterPack hooks for better packaging
  • Upgraded dependencies including Electron (34.2.0 → 39.2.7) and several document processing libraries
  • Standardized code formatting across the codebase using Prettier

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
styles.css Added accessibility classes (sr-only, file-input-hidden, manage-info) and applied Prettier formatting
scripts/prepare-canvas-dirs.js New script to ensure canvas platform directories exist for Windows builds
renderer.js Applied consistent code formatting (spacing, quotes, trailing commas)
package.json Updated dependencies, added format scripts, restructured build configuration with new Windows-specific options
main.js Improved path handling with explicit join and formatting cleanup
index.html Enhanced accessibility with lang attribute, meta tags, sr-only labels for screen readers
fileProcessor.js Changed pdf-parse to use createRequire for compatibility and applied formatting
build-scripts/afterPack.cjs New script to handle post-packaging file copying for the build process
all.min.css Reformatted minified CSS with Prettier (expanded format)
README.md Cleaned up trailing whitespace and improved formatting consistency
.prettierignore New file to exclude specific directories from Prettier formatting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build-scripts/afterPack.cjs
Comment thread build-scripts/afterPack.cjs Outdated
Comment thread renderer.js Outdated
@DickHorner
Copy link
Copy Markdown
Author

DickHorner commented Dec 25, 2025

This pull request introduces several improvements and fixes across the codebase to enhance maintainability, packaging, and user experience. The most significant changes include the addition of a custom after-pack script for Electron builds, improvements to accessibility and HTML structure, updates to dependencies and build scripts, and consistent formatting and logging. Below are the most important changes grouped by theme:

Build and Packaging Improvements

  • Added a custom afterPack script (build-scripts/afterPack.cjs) to ensure all necessary files and directories (including assets, models, webfonts, and node_modules) are properly copied into the Electron app bundle during packaging. This improves reliability of packaged builds.
  • Updated .prettierignore to exclude build artifacts and large directories from formatting, reducing unnecessary processing.
  • Enhanced package.json build configuration: added new scripts for formatting and Windows build preparation, updated dependency versions, and improved build output and file inclusion/exclusion rules for cleaner distribution.

Accessibility and HTML/CSS Enhancements

  • Improved index.html accessibility by adding appropriate lang attributes, meta tags, and visually hidden labels for form controls. Also refactored structure and classes for clarity and maintainability. [1] [2] [3] [4] [5]

Dependency and Code Modernization

  • Updated key dependencies (mammoth, docx, pdf-parse, electron, electron-builder) to more recent versions for better compatibility and security.
  • Refactored fileProcessor.js to use createRequire for importing CommonJS modules (like pdf-parse) in an ES module environment, improving compatibility.

Code Consistency and Logging

Documentation

  • Updated README.md for clarity in installation steps and added minor formatting improvements for easier onboarding. [1] [2]

DickHorner and others added 2 commits December 25, 2025 02:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants