Skip to content

[16.0][IMP] purchase_request_approval: remove delete record for user #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PiyaChaiyanit wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] purchase_request_approval: remove delete record for user #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eb3f48e
remove delete record for user
PiyaChaiyanit May 26, 2026
dfd68b5
Merge branch '16.0' into 16.0-hide-pa-delete_button
PiyaChaiyanit May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions purchase_request_approval/models/purchase_request_approval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,8 @@ def _can_be_deleted(self):
return self.state == "draft"

def unlink(self):
if not self.env.user.has_group("purchase_request.group_purchase_request_manager"):
raise UserError(_("You do not have permission to delete purchase approvals."))
for rec in self:
if not rec._can_be_deleted():
raise UserError(
Expand Down
4 changes: 2 additions & 2 deletions purchase_request_approval/security/ir.model.access.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
access_purchase_request_approval_user,purchase.request.approval,model_purchase_request_approval,purchase_request.group_purchase_request_user,1,1,1,1
access_purchase_request_approval_employee,purchase.request.approval,model_purchase_request_approval,purchase_request_kmitl.group_purchase_request_user_all,1,1,1,1
access_purchase_request_approval_user,purchase.request.approval,model_purchase_request_approval,purchase_request.group_purchase_request_user,1,1,1,0
access_purchase_request_approval_employee,purchase.request.approval,model_purchase_request_approval,purchase_request_kmitl.group_purchase_request_user_all,1,1,1,0
access_purchase_request_approval_manager,purchase.request.approval,model_purchase_request_approval,purchase_request.group_purchase_request_manager,1,1,1,1
4 changes: 2 additions & 2 deletions purchase_request_approval/security/purchase_request_approval.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
<field name="perm_unlink" eval="False" />
<field name="domain_force">[('requested_by','=',user.id)]</field>
</record>
<record id="purchase_request_approval_user_all_rule" model="ir.rule">
Expand All @@ -47,7 +47,7 @@
<field name="perm_read" eval="True" />
<field name="perm_write" eval="True" />
<field name="perm_create" eval="True" />
<field name="perm_unlink" eval="True" />
<field name="perm_unlink" eval="False" />
<field name="domain_force">[(1,'=',1)]</field>
</record>
<record id="purchase_request_approval_manager_rule" model="ir.rule">
Expand Down