[16.0][IMP] multiple: replace attrs readonly with can_edit computed field#796
Open
madara1150 wants to merge 1 commit into
Open
[16.0][IMP] multiple: replace attrs readonly with can_edit computed field#796madara1150 wants to merge 1 commit into
madara1150 wants to merge 1 commit into
Conversation
…ield Refactor state-based attrs readonly conditions across 7 modules into a centralized can_edit computed Boolean field on each model. This removes duplicated readonly logic from XML views and makes future state changes require only a single model-level update. Modules affected: - advance_payment (advance.payment) - agx_sarabun (sarabun.document) - budget (budget.transfer) - budget_appropriation (budget.appropriation) - hr_recruitment_kmitl (hr.onboarding) - procurement_plan (reuse existing can_edit, fix remaining 6 XML fields) - purchase_request_approval_disbursement (purchase.request.approval)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modules changed
Pattern
Before (XML):
```xml
```
After (Python model):
```python
can_edit = fields.Boolean(compute="_compute_can_edit")
@api.depends("state")
def _compute_can_edit(self):
for rec in self:
rec.can_edit = rec.state == "draft"
```
After (XML):
```xml
```
Out of scope
Test plan