Skip to content

Commit 9241432

Browse files
committed
Remove SDK default ASR vendor fallback
Stop injecting asr.vendor=ares when no STT vendor is configured and rely on the API to apply its own default fallback instead.
1 parent 4f83e51 commit 9241432

3 files changed

Lines changed: 29 additions & 3 deletions

File tree

src/agora_agent/agentkit/agent.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1077,8 +1077,6 @@ def _resolve_llm_config(self) -> typing.Dict[str, typing.Any]:
10771077

10781078
def _resolve_asr_config(self, turn_detection_config: TurnDetectionInput) -> typing.Dict[str, typing.Any]:
10791079
asr_config = dict(self._stt or {})
1080-
if not asr_config:
1081-
asr_config["vendor"] = "ares"
10821080
asr_config["language"] = self._field_value(turn_detection_config, "language")
10831081
return asr_config
10841082

tests/custom/test_request_body.py

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -327,6 +327,34 @@ def test_byok_pipeline_full_properties_shape() -> None:
327327
assert tts["params"]["voice_id"] == "voice123"
328328

329329

330+
def test_session_start_properties_without_stt_does_not_inject_default_asr_vendor() -> None:
331+
agent = (
332+
Agent(test_client(), turn_detection={"language": "zh-CN"})
333+
.with_llm(
334+
OpenAI(
335+
api_key="openai-key",
336+
base_url="https://api.openai.com/v1/chat/completions",
337+
model="gpt-4o-mini",
338+
)
339+
)
340+
.with_tts(
341+
ElevenLabsTTS(
342+
key="el-key",
343+
model_id="eleven_flash_v2_5",
344+
voice_id="voice123",
345+
base_url="wss://api.elevenlabs.io/v1",
346+
)
347+
)
348+
)
349+
350+
props = build_properties(agent, allow_missing={"asr"})
351+
352+
assert props["asr"] == {
353+
"language": "zh-CN",
354+
}
355+
assert props["turn_detection"] == {"language": "zh-CN"}
356+
357+
330358
def test_session_start_properties_preserves_turn_detection_asr_language() -> None:
331359
"""session.start() must keep asr.language from turn_detection (matches agora-agents-ts)."""
332360
from agora_agent.agentkit.vendors.cn import TencentSTT

tests/custom/test_stt_language.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def test_invalid_turn_detection_language_is_rejected() -> None:
8181
def test_default_turn_detection_language_is_sent_without_stt() -> None:
8282
props = properties(base_agent())
8383

84-
assert props["asr"] == {"vendor": "ares", "language": "en-US"}
84+
assert props["asr"] == {"language": "en-US"}
8585
assert props["turn_detection"] == {"language": "en-US"}
8686

8787

0 commit comments

Comments
 (0)