feat: export computeTargetBalances and prod-network for yds consumption#12679
Open
samsiegart wants to merge 1 commit into
Open
feat: export computeTargetBalances and prod-network for yds consumption#12679samsiegart wants to merge 1 commit into
samsiegart wants to merge 1 commit into
Conversation
3e40e08 to
e86efd4
Compare
e86efd4 to
aecd780
Compare
aecd780 to
e3aef62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://linear.app/agoric/issue/AGO-573/make-computeweightedtargets-and-prod-networkts-quickly-consumable-from
Summary
Implements AGO-573 by making the YMax target-balance logic and production network spec consumable outside this repo.
computeWeightedTargetsfromservices/ymax-plannerinto@agoric/portfolio-apiascomputeTargetBalancesprod-network.ts/network-spec.tsinto@agoric/portfolio-api/src/networkpackages/portfolio-contract/tools/network/prod-network.tsas a compatibility re-exportpackages/portfolio-contract/tools/target-balances.tsas a compatibility re-export@agoric/portfolio-apiReviewer Notes
Most of the large diff is moved code, not new behavior:
prod-network.tsis copied fromportfolio-contract/tools/networkintoportfolio-api/src/networknetwork-spec.tsis copied with import/type-source cleanupcomputeTargetBalancesis the formercomputeWeightedTargets, adapted from a planner-private helper into an exported APIThe old behavior coverage remains in
services/ymax-planner/test/deposit-tools.test.ts