Skip to content

chore(portfolio-deploy): make mainnet deployment more robust#12680

Open
dckc wants to merge 5 commits into
masterfrom
dc-ymax-ops
Open

chore(portfolio-deploy): make mainnet deployment more robust#12680
dckc wants to merge 5 commits into
masterfrom
dc-ymax-ops

Conversation

@dckc
Copy link
Copy Markdown
Member

@dckc dckc commented May 22, 2026

Description / Upgrade Considerations

  • fix namespace for main
  • KLUDGE around RPC load balancer
  • retry getGoodLogs
  • avoid swallowing errors / stack traces
  • adjust job preconditions

Security / Scaling / Documentation Considerations

n/a

Testing Considerations

https://github.com/Agoric/agoric-sdk/releases/tag/ymax-v0.3.2605-beta1 is an integration test
along with several runs up to https://github.com/Agoric/agoric-sdk/actions/runs/26269136326/job/77318699362

@dckc dckc requested review from LuqiPan and michaelfig May 22, 2026 05:07
@dckc dckc marked this pull request as ready for review May 22, 2026 05:09
@dckc dckc added the bypass:integration Prevent integration tests from running on PR label May 22, 2026
@dckc dckc requested a review from Muneeb147 May 22, 2026 14:20
Comment on lines +52 to +53
// KLUDGE! avoid flaky load-balanced setup
rpcAddrMainGood = 'https://rpc.agoric-main-eu1.ccvalidators.com:443',
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muneeb147 and I agreed that /network-config should take care of providing a working RPC node.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes
Once SRE calls-out that main.agoric.net/network-config is providing stable rpcAddr, until then it's fine to use ccvalidators (as it's the same upstream which we use)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to you @dckc ?

Copy link
Copy Markdown
Member Author

@dckc dckc May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to take this KLUDGE out before landing this PR.
If I see any more RPC trouble, I'll count on SRE to fix it by adjusting /network-config.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second it.
Let's rely on /network-config which points to main.rpc.agoric.net rpcAddr.
I have checked it is healthy as expected.

image

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But do have retries while hitting this rpc? Incase of any intermittent failure response...

@dckc dckc changed the title chore(portfolio-deploy): address mainnet deployment papercuts chore(portfolio-deploy): make mainnet deployment more robust May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bypass:integration Prevent integration tests from running on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants