fix: format and BinderServerBuilder

Author: AgraVator

binder/src/main/java/io/grpc/binder/BinderServerBuilder.java

@@ -68,7 +68,7 @@ private BinderServerBuilder(
 
     serverImplBuilder =
         new ServerImplBuilder(
-            streamTracerFactories -> {
+            (streamTracerFactories, metricRecorder) -> {
               internalBuilder.setStreamTracerFactories(streamTracerFactories);
               BinderServer server = internalBuilder.build();
               BinderInternal.setIBinder(binderReceiver, server.getHostBinder());

core/src/main/java/io/grpc/internal/InternalServer.java

@@ -58,8 +58,7 @@ public interface InternalServer {
   /**
    * Returns the first listen socket stats of this server. May return {@code null}.
    */
-  @Nullable
-  InternalInstrumented<SocketStats> getListenSocketStats();
+  @Nullable InternalInstrumented<SocketStats> getListenSocketStats();
 
   /**
    * Returns a list of listening socket addresses.  May change after {@link #start(ServerListener)}
@@ -70,7 +69,6 @@ public interface InternalServer {
   /**
    * Returns a list of listen socket stats of this server. May return {@code null}.
    */
-  @Nullable
-  List<InternalInstrumented<SocketStats>> getListenSocketStatsList();
+  @Nullable List<InternalInstrumented<SocketStats>> getListenSocketStatsList();
 
 }

core/src/main/java/io/grpc/internal/ServerImpl.java

@@ -143,7 +143,6 @@ public final class ServerImpl extends io.grpc.Server implements InternalInstrume
       InternalServer transportServer,
       Context rootContext) {
     this.executorPool = Preconditions.checkNotNull(builder.executorPool, "executorPool");
-
     this.registry = Preconditions.checkNotNull(builder.registryBuilder.build(), "registryBuilder");
     this.fallbackRegistry =
         Preconditions.checkNotNull(builder.fallbackRegistry, "fallbackRegistry");

netty/src/main/java/io/grpc/netty/TcpMetrics.java

@@ -151,14 +151,12 @@ static final class Tracker {
     private ScheduledFuture<?> reportTimer;
 
     void channelActive(Channel channel) {
-      if (metricRecorder != null) {
-        List<String> labelValues = getLabelValues(channel);
-        metricRecorder.addLongCounter(metrics.connectionsCreated, 1,
-            Collections.emptyList(), labelValues);
-        metricRecorder.addLongUpDownCounter(metrics.connectionCount, 1,
-            Collections.emptyList(), labelValues);
-        scheduleNextReport(channel, true);
-      }
+      List<String> labelValues = getLabelValues(channel);
+      metricRecorder.addLongCounter(metrics.connectionsCreated, 1,
+          Collections.emptyList(), labelValues);
+      metricRecorder.addLongUpDownCounter(metrics.connectionCount, 1,
+          Collections.emptyList(), labelValues);
+      scheduleNextReport(channel, true);
     }
 
     private void scheduleNextReport(final Channel channel, boolean isInitial) {
@@ -188,21 +186,19 @@ void channelInactive(Channel channel) {
       if (reportTimer != null) {
         reportTimer.cancel(false);
       }
-      if (metricRecorder != null) {
-        List<String> labelValues = getLabelValues(channel);
-        metricRecorder.addLongUpDownCounter(metrics.connectionCount, -1,
-            Collections.emptyList(), labelValues);
-        // Final collection on close
-        recordTcpInfo(channel, true);
-      }
+      List<String> labelValues = getLabelValues(channel);
+      metricRecorder.addLongUpDownCounter(metrics.connectionCount, -1,
+          Collections.emptyList(), labelValues);
+      // Final collection on close
+      recordTcpInfo(channel, true);
     }
 
     void recordTcpInfo(Channel channel) {
       recordTcpInfo(channel, false);
     }
 
     private void recordTcpInfo(Channel channel, boolean isClose) {
-      if (metricRecorder == null || epollSocketChannelClass == null
+      if (epollSocketChannelClass == null
           || !epollSocketChannelClass.isInstance(channel)) {
         return;
       }