Skip to content

Commit 3859ae5

Browse files
committed
fix test cases
1 parent f3f49b6 commit 3859ae5

2 files changed

Lines changed: 2 additions & 18 deletions

File tree

core/src/main/java/io/grpc/internal/ManagedChannelImplBuilder.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public static ManagedChannelBuilder<?> forTarget(String target) {
155155

156156
private final List<ClientInterceptor> interceptors = new ArrayList<>();
157157
NameResolverRegistry nameResolverRegistry = NameResolverRegistry.getDefaultRegistry();
158-
boolean registryProvided;
158+
159159
@Nullable
160160
NameResolverProvider nameResolverProvider;
161161

@@ -344,7 +344,6 @@ public ManagedChannelImplBuilder(
344344
}
345345
if (nameResolverRegistry != null) {
346346
this.nameResolverRegistry = nameResolverRegistry;
347-
this.registryProvided = true;
348347
}
349348
if (nameResolverProvider != null) {
350349
this.nameResolverProvider = nameResolverProvider;
@@ -469,8 +468,7 @@ public ManagedChannelImplBuilder nameResolverFactory(NameResolver.Factory resolv
469468
Preconditions.checkState(directServerAddress == null,
470469
"directServerAddress is set (%s), which forbids the use of NameResolverFactory",
471470
directServerAddress);
472-
Preconditions.checkState(!registryProvided,
473-
"nameResolverRegistry is already set, which forbids the use of NameResolverFactory");
471+
474472
if (resolverFactory != null) {
475473
NameResolverRegistry reg = new NameResolverRegistry();
476474
if (resolverFactory instanceof NameResolverProvider) {
@@ -487,7 +485,6 @@ public ManagedChannelImplBuilder nameResolverFactory(NameResolver.Factory resolv
487485

488486
ManagedChannelImplBuilder nameResolverRegistry(NameResolverRegistry resolverRegistry) {
489487
this.nameResolverRegistry = resolverRegistry;
490-
this.registryProvided = true;
491488
return this;
492489
}
493490

core/src/test/java/io/grpc/internal/ManagedChannelImplBuilderTest.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -803,19 +803,6 @@ public void uriPattern() {
803803

804804
private static class CustomSocketAddress extends SocketAddress {}
805805

806-
@Test
807-
@SuppressWarnings("deprecation")
808-
public void nameResolverFactory_notAllowedAfterRegistry() {
809-
NameResolverRegistry registry = new NameResolverRegistry();
810-
builder.nameResolverRegistry(registry);
811-
try {
812-
builder.nameResolverFactory(mock(NameResolver.Factory.class));
813-
fail("Should throw");
814-
} catch (IllegalStateException e) {
815-
assertThat(e).hasMessageThat().contains("nameResolverRegistry is already set");
816-
}
817-
}
818-
819806
@Test
820807
public void getNameResolverProvider_explicitProviderWithIpTarget() {
821808
String target = "127.0.0.1:8080";

0 commit comments

Comments
 (0)