Skip to content

Commit a24b798

Browse files
committed
opentelemetry: Remove mock delay tracing test in favor of real SDK span verification and simplify AttributeKey references
1 parent c692f73 commit a24b798

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

opentelemetry/src/test/java/io/grpc/opentelemetry/OpenTelemetryTracingModuleTest.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,7 @@
6363
import io.grpc.testing.GrpcServerRule;
6464
import io.opentelemetry.api.OpenTelemetry;
6565
import io.opentelemetry.api.baggage.Baggage;
66+
import io.opentelemetry.api.common.AttributeKey;
6667
import io.opentelemetry.api.trace.Span;
6768
import io.opentelemetry.api.trace.SpanBuilder;
6869
import io.opentelemetry.api.trace.SpanContext;
@@ -412,29 +413,29 @@ public void clientAttemptDelayTracing_reasonChangedInvariant() {
412413

413414
assertEquals("Attempt Delay", delaySpanData.getName());
414415
assertEquals("connecting", delaySpanData.getAttributes().get(
415-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_type")));
416+
AttributeKey.stringKey("grpc.delay_type")));
416417
assertEquals(3, delaySpanData.getEvents().size());
417418

418419
EventData event1 = delaySpanData.getEvents().get(0);
419420
assertEquals("Delay state transition", event1.getName());
420421
assertEquals("connecting", event1.getAttributes().get(
421-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_type")));
422+
AttributeKey.stringKey("grpc.delay_type")));
422423
assertEquals("reason1", event1.getAttributes().get(
423-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_reason")));
424+
AttributeKey.stringKey("grpc.delay_reason")));
424425

425426
EventData event2 = delaySpanData.getEvents().get(1);
426427
assertEquals("Delay state transition", event2.getName());
427428
assertEquals("connecting", event2.getAttributes().get(
428-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_type")));
429+
AttributeKey.stringKey("grpc.delay_type")));
429430
assertEquals("reason2", event2.getAttributes().get(
430-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_reason")));
431+
AttributeKey.stringKey("grpc.delay_reason")));
431432

432433
EventData event3 = delaySpanData.getEvents().get(2);
433434
assertEquals("Delay state transition", event3.getName());
434435
assertEquals("connecting", event3.getAttributes().get(
435-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_type")));
436+
AttributeKey.stringKey("grpc.delay_type")));
436437
assertEquals("reason3", event3.getAttributes().get(
437-
io.opentelemetry.api.common.AttributeKey.stringKey("grpc.delay_reason")));
438+
AttributeKey.stringKey("grpc.delay_reason")));
438439
}
439440

440441
@Test

0 commit comments

Comments
 (0)