impl: added more testing coverage

Author: spin3l

_data/transformations/algorithm

@@ -0,0 +1 @@
+TEST_ENV_KEY=987

ocean_runner/config.py

@@ -1,4 +1,4 @@
-from enum import StrEnum, auto
+from enum import Enum
 from logging import Logger
 from pathlib import Path
 from typing import Generic, Sequence, Type, TypeVar
@@ -11,11 +11,11 @@
 DEFAULT = "DEFAULT"
 
 
-class Keys(StrEnum):
-    SECRET = auto()
-    BASE_DIR = auto()
-    TRANSFORMATION_DID = auto()
-    DIDS = auto()
+class Keys(str, Enum):
+    SECRET = "secret"
+    BASE_DIR = "base_dir"
+    TRANSFORMATION_DID = "transformation_did"
+    DIDS = "dids"
 
 
 class Environment(BaseSettings):

ocean_runner/entrypoint.py

@@ -24,7 +24,10 @@ class CLIRunnerConfig(BaseModel):
         description="The python module path to import (e.g. 'src.algorithm')",
     )
 
-    base_dir: Path = Field(default=Path("../_data"), description="Base data path")
+    base_dir: Path = Field(
+        default=Path("../_data"),
+        description="Base data path",
+    )
 
     def model_post_init(self, context, /) -> None:
         if not self.base_dir.exists():

ocean_runner/runner.py

@@ -15,7 +15,6 @@
     TypeVar,
     cast,
     overload,
-    override,
 )
 
 from oceanprotocol_job_details import (
@@ -26,7 +25,8 @@
 )
 from oceanprotocol_job_details.ocean import _BaseJobDetails
 from pydantic import BaseModel, JsonValue
-from returns.result import Success, Failure
+from returns.result import Failure, Success
+from typing_extensions import override
 
 from ocean_runner.config import Config
 
@@ -110,7 +110,7 @@ def create(cls, config: Config[None]) -> EmptyAlgorithm[ResultT]:
 
     @overload
     @classmethod
-    def create(cls, config: None) -> EmptyAlgorithm[ResultT]:
+    def create(cls, config: None = None) -> EmptyAlgorithm[ResultT]:
         pass  # pragma: no cover
 
     @classmethod
@@ -191,7 +191,9 @@ def on_error(self, fn: ErrorFuncT) -> ErrorFuncT:
     # Execution Pipeline
     # ---------------------------
 
-    async def execute(self) -> ResultT | None:
+    def load(self) -> None:
+        """Load the JobDetails instance"""
+
         env = self.configuration.environment
         config: Dict[str, JsonValue] = {
             "base_dir": str(env.base_dir),
@@ -206,8 +208,10 @@ async def execute(self) -> ResultT | None:
             custom_input = self.configuration.custom_input
 
         self._job_details = load_job_details(custom_input, config)
+        self._job_details.paths.outputs.mkdir(exist_ok=True)
         self.logger.info("Loaded JobDetails")
 
+    async def execute(self) -> ResultT | None:
         try:
             await run_in_executor(
                 self._functions.validate,
@@ -219,8 +223,6 @@ async def execute(self) -> ResultT | None:
                 self,
             )
 
-            self._job_details.paths.outputs.mkdir(exist_ok=True)
-
             await run_in_executor(
                 self._functions.save,
                 self,
@@ -239,6 +241,7 @@ def job_details(self) -> _BaseJobDetails[InputT]: ...
 
     def __call__(self) -> ResultT | None:
         """Executes the algorithm pipeline: validate → run → save_results."""
+        self.load()
         return asyncio.run(self.execute())
 
 
@@ -253,8 +256,8 @@ def job_details(self) -> ParametrizedJobDetails[InputT]:
                 return parametrized_job_details
             case Failure(error):
                 raise error
-
-        return self._job_details.read().unwrap()
+            case _:  # pragma: no cover
+                raise RuntimeError("Unreachable code")
 
 
 class EmptyAlgorithm(Algorithm[None, ResultT]):

tests/test_entrypoint.py

@@ -1,4 +1,6 @@
+import sys
 from importlib.metadata import PackageNotFoundError
+from pathlib import Path
 from unittest.mock import MagicMock, patch
 
 import pytest
@@ -9,6 +11,8 @@
     get_config,
     get_version,
     main,
+    main_test,
+    run_tests,
 )
 from ocean_runner.runner import Algorithm
 
@@ -29,6 +33,12 @@ def test_config_validation_custom_args():
     assert config.base_dir.exists()
 
 
+@patch("pathlib.Path.exists", return_value=False)
+def test_config_validation_raises_if_bad_path(mock_exists):
+    with pytest.raises(FileNotFoundError):
+        get_config(["custom.path", "--base-dir", "./_data"])
+
+
 @patch("importlib.import_module")
 def test_get_algorithm_success(mock_import):
     """Test that get_algorithm correctly finds an Algorithm instance."""
@@ -57,7 +67,7 @@ def test_get_algorithm_no_instance(mock_import):
 @patch("ocean_runner.entrypoint.get_algorithm")
 @patch(
     "ocean_runner.entrypoint.get_config",
-    return_value=CLIRunnerConfig(module="test.mod", base_dir="./_data"),
+    return_value=CLIRunnerConfig(module="test.mod", base_dir=Path("./_data")),
 )
 def test_main_execution_flow(mock_get_config, mock_get_algo):
     """Test the full main loop triggers the algorithm call."""
@@ -74,7 +84,7 @@ def test_main_execution_flow(mock_get_config, mock_get_algo):
 @patch("ocean_runner.entrypoint.get_algorithm", return_value=None)
 @patch(
     "ocean_runner.entrypoint.get_config",
-    return_value=CLIRunnerConfig(module="bad.mod", base_dir="./_data"),
+    return_value=CLIRunnerConfig(module="bad.mod", base_dir=Path("./_data")),
 )
 def test_main_failure_exit(mock_get_config, mock_get_algo):
     """Test that the runner exits with code 1 if no algorithm is found."""
@@ -91,3 +101,78 @@ def test_version(mock_version):
 @patch("ocean_runner.entrypoint.version", side_effect=PackageNotFoundError())
 def test_version_failing(mock_version):
     assert "unknown" in get_version()
+
+
+@patch("importlib.import_module", side_effect=ImportError())
+def test_import_algorithm_error(mock_import, capsys):
+    result = get_algorithm("test")
+
+    captured = capsys.readouterr()
+
+    assert result is None
+    assert "Error loading" in captured.err
+
+
+def test_import_not_in_path():
+    fake_cwd = "/fake/path"
+
+    with patch("os.getcwd", return_value=fake_cwd):
+        with patch("sys.path", []):
+            get_algorithm("some.module")
+
+            assert fake_cwd in sys.path
+
+
+@patch("sys.exit")
+@patch("pytest.main", return_value=0)
+@patch("ocean_runner.entrypoint.setup_environment")
+def test_run_tests(mock_setup_env, mock_pytest_main, mock_exit, capsys):
+    config = MagicMock()
+    config.base_dir = Path("/tmp/project")
+
+    args = ["-k", "test_something"]
+
+    run_tests(config, args)
+
+    # Check environment setup
+    mock_setup_env.assert_called_once_with(config.base_dir)
+
+    # Check pytest execution
+    mock_pytest_main.assert_called_once_with(args)
+
+    # Check exit called with pytest result
+    mock_exit.assert_called_once_with(0)
+
+    # Check printed message
+    captured = capsys.readouterr()
+    assert "Preparing Test Environment at:" in captured.out
+
+
+@patch("ocean_runner.entrypoint.run_tests")
+@patch("ocean_runner.entrypoint.setup")
+def test_main_test_with_separator(mock_setup, mock_run_tests):
+    mock_config = MagicMock()
+    mock_setup.return_value = mock_config
+
+    test_argv = ["prog", "--config", "dev", "--", "-k", "test_api"]
+
+    with patch("sys.argv", test_argv):
+        main_test()
+
+    mock_setup.assert_called_once_with(["--config", "dev"])
+    mock_run_tests.assert_called_once_with(mock_config, ["-k", "test_api"])
+
+
+@patch("ocean_runner.entrypoint.run_tests")
+@patch("ocean_runner.entrypoint.setup")
+def test_main_test_without_separator(mock_setup, mock_run_tests):
+    mock_config = MagicMock()
+    mock_setup.return_value = mock_config
+
+    test_argv = ["prog", "--config", "dev"]
+
+    with patch("sys.argv", test_argv):
+        main_test()
+
+    mock_setup.assert_called_once_with(["--config", "dev"])
+    mock_run_tests.assert_called_once_with(mock_config, ["tests"])

tests/test_runner.py

@@ -1,3 +1,5 @@
+from returns.result import Failure
+from unittest.mock import patch
 import logging
 from functools import partial
 from pathlib import Path
@@ -41,7 +43,7 @@ def _(_) -> int:
     yield algorithm
 
 
-def test_algorithm_without_config_raises():
+def test_algorithm_without_config_does_not_raise():
     Algorithm.create()
 
 
@@ -73,6 +75,23 @@ def test_parametrized_job_details(config: Config[CustomInput]):
     assert algorithm.job_details.input_parameters.isTrue
 
 
+def test_parametrized_job_details_failure_reading(config: Config[CustomInput]):
+    class MockError(BaseException): ...
+
+    config = config.model_copy()
+    config.custom_input = CustomInput
+
+    algorithm = Algorithm[CustomInput, int].create(config)
+    algorithm.load()
+
+    with patch(
+        "oceanprotocol_job_details.JobDetails.read",
+        return_value=Failure(MockError()),
+    ):
+        with raises(MockError):
+            algorithm.job_details
+
+
 def test_empty_job_details_raises(config):
     algorithm = Algorithm.create(config=config)