Skip to content

Package the package, use the package in CI#30

Open
sneakers-the-rat wants to merge 1 commit into
mainfrom
packaging
Open

Package the package, use the package in CI#30
sneakers-the-rat wants to merge 1 commit into
mainfrom
packaging

Conversation

@sneakers-the-rat
Copy link
Copy Markdown

What and why?

python code is ostensibly packaged, with presence of pyproject.toml, however repository structure is not structured like a package and setuptools package discovery errors because there are multiple possible implicit package directories. this means that one cannot install the deps locally even if one is just intending to use it as a repository script (the validator assumes it is being run in the repository root, so code is not necessarily intended/capable of operating like a library) and has to do it manually.

dependencies are specified in the pyproject.toml but they are not used in CI, CI instead just manually installs the deps.

if deps change in the future, e.g. say to use code from the klc validator and move all the code in the workflow definition into the package, then those have to be manually maintained and kept synchronized.

so instead, just specify the validator as the package and use the deps specified in pyproject.toml in CI.

Tested in KiCad?

  • No — no changes to kicad files

@github-actions
Copy link
Copy Markdown

Library Validation Report ✅

Overall Status: PASS

Check Result
Tests ✅ Passed
KLC Validation ✅ Passed

Validation Report: PASS

Structure

Check Result
Duplicate symbols pass
Library tables pass
Naming conventions pass
Uncategorized files pass
Table generation pass

Generated by CI — view workflow run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant