Package the package, use the package in CI#30
Open
sneakers-the-rat wants to merge 1 commit into
Open
Conversation
Library Validation Report ✅Overall Status: PASS
Validation Report: PASSStructure
Generated by CI — view workflow run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
python code is ostensibly packaged, with presence of
pyproject.toml, however repository structure is not structured like a package and setuptools package discovery errors because there are multiple possible implicit package directories. this means that one cannot install the deps locally even if one is just intending to use it as a repository script (the validator assumes it is being run in the repository root, so code is not necessarily intended/capable of operating like a library) and has to do it manually.dependencies are specified in the
pyproject.tomlbut they are not used in CI, CI instead just manually installs the deps.if deps change in the future, e.g. say to use code from the klc validator and move all the code in the workflow definition into the package, then those have to be manually maintained and kept synchronized.
so instead, just specify the validator as the package and use the deps specified in pyproject.toml in CI.
Tested in KiCad?