Merge pull request #439 from AhmedLSayed9/revert-438-inherit_local_input_decoration_theme

Revert "Inherit local InputDecorationTheme (contentPadding, border, visualDensity) instead of only the global theme"

Author: AhmedLSayed9

packages/dropdown_button2/CHANGELOG.md

@@ -9,7 +9,6 @@
 - Re-lay out dropdown menu on ancestor scroll.
 - Add `barrierBlocksInteraction` to allow interaction with underlying widgets while the dropdown menu is open.
 - Properly dispose internal FocusNode when replaced by an external FocusNode.
-- Inherit local `InputDecorationTheme` (contentPadding, border, visualDensity) instead of only the global theme.
 
 ## 3.0.0
 

packages/dropdown_button2/lib/src/dropdown_button2.dart

@@ -633,24 +633,23 @@ class _DropdownButton2State<T> extends State<DropdownButton2<T>> with WidgetsBin
   EdgeInsets? _getInputDecorationPadding() {
     // Return the contentPadding only if inputDecoration is defined.
     if (widget._inputDecoration case final decoration?) {
-      final InputDecorationThemeData inputDecorationTheme = InputDecorationTheme.of(context);
+      final ThemeData theme = Theme.of(context);
       final TextDirection? textDirection = Directionality.maybeOf(context);
 
       final EdgeInsets? contentPadding =
-          (decoration.contentPadding ?? inputDecorationTheme.contentPadding)?.resolve(
+          (decoration.contentPadding ?? theme.inputDecorationTheme.contentPadding)?.resolve(
             textDirection,
           );
 
       // InputDecorator adds gapPadding horizontally for OutlineInputBorder.
-      final border = decoration.border ?? inputDecorationTheme.border;
+      final border = decoration.border ?? theme.inputDecorationTheme.border;
       final double gapPadding = switch (border) {
         OutlineInputBorder(:final gapPadding) => gapPadding,
         _ => 0.0,
       };
 
-      final Offset densityOffset =
-          (inputDecorationTheme.visualDensity ?? Theme.of(context).visualDensity)
-              .baseSizeAdjustment;
+      // Use inputDecorationTheme.visualDensity when added (https://github.com/flutter/flutter/issues/166201#issuecomment-2774622584)
+      final Offset densityOffset = theme.visualDensity.baseSizeAdjustment;
 
       return contentPadding?.copyWith(
         left: contentPadding.left + gapPadding,
@@ -1149,7 +1148,7 @@ class DropdownButtonFormField2<T> extends FormField<T> {
            final _DropdownButtonFormField2State<T> state =
                field as _DropdownButtonFormField2State<T>;
            InputDecoration effectiveDecoration = (decoration ?? const InputDecoration())
-               .applyDefaults(InputDecorationTheme.of(field.context));
+               .applyDefaults(Theme.of(field.context).inputDecorationTheme);
 
            final bool showSelectedItem =
                items != null &&