Add knip: detect dead files, exports, types across the project

Adds knip@6 with flat config in knip.json. Declares runtime entry
points (index.ts, workers, mllp, BAR services, v2-to-fhir processor),
script entries (scripts/**), and test entries.

Cleanup to reach 0 findings:
- Deleted 8 unused barrel files: src/bar/index.ts, src/code-mapping/
  index.ts, src/mllp/index.ts, src/v2-to-fhir/index.ts,
  src/v2-to-fhir/{code-mapping,datatypes,messages,segments}/index.ts.
  Nothing imported them — were likely leftovers from an earlier
  extraction plan.
- Removed 23 redundant `export default` lines from converter modules
  (adt-a01/a03/a08, oru-r01, vxu-v04, pid-patient, SAD/ST/XAD/XCN/XON/
  XPN/XTN datatype converters, NK1/DG1/AL1/IN1 segment converters).
  All had both a named export and a default for the same function;
  default was never imported.
- De-exported 49 unused named exports across ~26 files
  (made file-private by dropping the `export` keyword).
- De-exported 91 unused exported types/interfaces across ~36 files
  (same pattern — kept as internal types for readability).
- Deleted genuinely dead code: getValidValuesWithDisplay +
  getDisplayForCode (mapping-type-options), convertXPNArrayToHumanNames
  (xpn-humanname), fetchConceptMap (concept-map/service — shadowed by
  test-local helper), plus a couple of dead re-exports.

Also wire `bun run knip` into test:local and test:all. Any new dead
file, export, or redundant export breaks the test loop.

Typecheck + lint stay at 0 errors/warnings. Unit tests unchanged
(1878 pass / 17 todo / 74 preexisting failures).

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-authored-by: Nikita Sintsev <nikita.sintsev@health-samurai.io>

Author: 3 people

bun.lock

@@ -0,0 +1,23 @@
+{
+  "$schema": "https://unpkg.com/knip@6/schema.json",
+  "entry": [
+    "src/workers.ts",
+    "src/bar/sender-service.ts",
+    "src/bar/account-builder-service.ts",
+    "src/v2-to-fhir/processor-service.ts",
+    "scripts/**/*.ts",
+    "test/**/*.test.ts",
+    "test/integration/preload.ts",
+    "test/integration/helpers.ts",
+    "test/unit/v2-to-fhir/helpers.ts"
+  ],
+  "project": [
+    "src/**/*.ts",
+    "scripts/**/*.ts",
+    "test/**/*.ts"
+  ],
+  "ignore": [
+    "src/fhir/**",
+    "src/hl7v2/generated/**"
+  ]
+}

knip.json

@@ -1,11 +1,12 @@
 {
   "name": "aidbox-hl7",
-  "module": "index.ts",
+  "module": "src/index.ts",
   "devDependencies": {
     "@eslint/js": "^10.0.1",
     "@types/bun": "latest",
     "eslint": "^10.2.1",
     "fast-xml-parser": "^5.3.5",
+    "knip": "^6.6.2",
     "typescript-eslint": "^8.59.0"
   },
   "peerDependencies": {
@@ -19,14 +20,15 @@
     "typecheck": "bash scripts/typecheck.sh",
     "lint": "eslint . --max-warnings 0",
     "lint:fix": "eslint . --fix --max-warnings 0",
+    "knip": "knip-bun",
     "mllp": "bun src/mllp/mllp-server.ts",
     "test-mllp": "bun scripts/test-mllp-client.ts",
     "regenerate-hl7v2": "bash scripts/regenerate-hl7v2.sh",
     "regenerate-fhir": "bun scripts/regenerate-fhir.ts",
     "generate-hl7v2-reference": "bun scripts/generate-hl7v2-reference.ts",
     "migrate": "bun src/migrate.ts",
-    "test:all": "bun run lint && bun test && bun test:integration",
-    "test:local": "bun run lint && bun test && bun test:smoke",
+    "test:all": "bun run lint && bun run knip && bun test && bun test:integration",
+    "test:local": "bun run lint && bun run knip && bun test && bun test:smoke",
     "test:unit": "bun test",
     "test:integration": "bun test --test-root ./test/integration --preload ./test/integration/preload.ts --max-concurrency=1",
     "test:smoke": "bun test --test-root ./test/integration --preload ./test/integration/preload.ts --max-concurrency=1 --test-name-pattern \"smoke: \"",

package.json

@@ -76,7 +76,7 @@ export async function resourceExists(
   }
 }
 
-export class PreconditionFailedError extends Error {
+class PreconditionFailedError extends Error {
   constructor(message: string) {
     super(message);
     this.name = "PreconditionFailedError";
@@ -90,7 +90,7 @@ export class NotFoundError extends Error {
   }
 }
 
-export interface ResourceWithETag<T> {
+interface ResourceWithETag<T> {
   resource: T;
   etag: string;
 }

src/aidbox.ts

@@ -41,7 +41,7 @@ export const DEMO_SAMPLE_IDS = [
 export const DEMO_WAIT_DEADLINE_MS = 8000;
 export const DEMO_POLL_INTERVAL_MS = 500;
 
-export interface RunDemoScenarioOptions {
+interface RunDemoScenarioOptions {
   send?: (host: string, port: number, message: string) => Promise<string>;
   sleep?: (ms: number) => Promise<void>;
   /** Fetch current status for a message by MSH-10. Inject for tests. */

src/api/demo-scenario.ts

@@ -28,7 +28,7 @@ import {
 /**
  * Get a value from a Task's input array by type text.
  */
-export function getTaskInputValue(
+function getTaskInputValue(
   task: Task,
   typeText: string,
 ): string | undefined {

src/api/task-resolution.ts

@@ -348,6 +348,3 @@ export function generateBarMessage(input: BarMessageInput): HL7v2Message {
     .addVISIT(buildVisit(input))
     .build();
 }
-
-// Re-export types
-export type { BarMessageInput } from "./types";

src/bar/generator.ts

@@ -14,7 +14,7 @@ import {
   type SenderContext,
 } from "./service";
 
-export interface CodeResolutionResult {
+interface CodeResolutionResult {
   loinc: Coding;
   local?: Coding;
 }
@@ -33,7 +33,7 @@ export class LoincResolutionError extends Error {
   }
 }
 
-export class MissingLocalSystemError extends Error {
+class MissingLocalSystemError extends Error {
   constructor(
     message: string,
     public readonly localCode: string | undefined,

src/bar/index.ts

@@ -45,16 +45,16 @@ export interface SenderContext {
  * Mapping type filter options for the UI.
  * "all" shows all mapping types.
  */
-export type MappingTypeFilter = MappingTypeName | "all";
+type MappingTypeFilter = MappingTypeName | "all";
 
-export interface ConceptMapSummary {
+interface ConceptMapSummary {
   id: string;
   displayName: string;
   mappingType: MappingTypeName;
   targetSystem: string;
 }
 
-export interface MappingEntry {
+interface MappingEntry {
   localCode: string;
   localDisplay: string;
   localSystem: string;
@@ -79,7 +79,7 @@ interface TranslateResponse {
   parameter?: TranslateResponseParameter[];
 }
 
-export type TranslateResult =
+type TranslateResult =
   | { status: "found"; coding: Coding }
   | { status: "no_mapping" }
   | { status: "not_found" };
@@ -92,7 +92,7 @@ export type TranslateResult =
  * Generate the base ConceptMap ID from sender context (without mapping type).
  * Format: hl7v2-{sendingApplication}-{sendingFacility}
  */
-export function generateBaseConceptMapId(sender: SenderContext): string {
+function generateBaseConceptMapId(sender: SenderContext): string {
   const app = toKebabCase(sender.sendingApplication);
   const facility = toKebabCase(sender.sendingFacility);
   return `hl7v2-${app}-${facility}`;
@@ -116,7 +116,7 @@ export function generateConceptMapId(
  * Format sender context as title string (format: "APP | FACILITY")
  * Used for ConceptMap.title field
  */
-export function formatSenderAsTitle(sender: SenderContext): string {
+function formatSenderAsTitle(sender: SenderContext): string {
   return `${sender.sendingApplication} | ${sender.sendingFacility}`;
 }
 
@@ -198,19 +198,6 @@ export async function translateCode(
 // ConceptMap CRUD operations
 // ============================================================================
 
-export async function fetchConceptMap(
-  conceptMapId: string,
-): Promise<ConceptMap | null> {
-  try {
-    return await aidboxFetch<ConceptMap>(`/fhir/ConceptMap/${conceptMapId}`);
-  } catch (error) {
-    if (error instanceof Error && error.message.includes("404")) {
-      return null;
-    }
-    throw error;
-  }
-}
-
 export function createEmptyConceptMap(
   sender: SenderContext,
   mappingType: MappingTypeName,
@@ -323,7 +310,7 @@ export function detectMappingTypeFromConceptMap(
 /**
  * Check if a mapping entry matches a search query
  */
-export function matchesSearch(entry: MappingEntry, search: string): boolean {
+function matchesSearch(entry: MappingEntry, search: string): boolean {
   const query = search.toLowerCase();
   return (
     entry.localCode.toLowerCase().includes(query) ||
@@ -336,7 +323,7 @@ export function matchesSearch(entry: MappingEntry, search: string): boolean {
 /**
  * Check if a mapping entry already exists
  */
-export function checkDuplicateEntry(
+function checkDuplicateEntry(
   conceptMap: ConceptMap,
   localSystem: string,
   localCode: string,