Skip to content

chore(deps): Support Python 3.13#3756

Open
reneleonhardt wants to merge 5 commits into
Aider-AI:mainfrom
reneleonhardt:chore/support-py3.13
Open

chore(deps): Support Python 3.13#3756
reneleonhardt wants to merge 5 commits into
Aider-AI:mainfrom
reneleonhardt:chore/support-py3.13

Conversation

@reneleonhardt

Copy link
Copy Markdown

Closes #3037

@CLAassistant

CLAassistant commented Apr 8, 2025

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@reneleonhardt

Copy link
Copy Markdown
Author

If the tests are green, please try yourself @paul-gauthier 😄

@reneleonhardt

Copy link
Copy Markdown
Author

FYI there were many llama-index-core releases since you pinned 0.12.26 3 weeks ago, maybe test_help will work again 🤞😅

numpy>=2

# Mac x86 only supports 2.2.2
# Drop Mac x86 support

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also #3444 (comment) for an ongoing discussion about keeping or dropping Mac x86 support.

@reneleonhardt reneleonhardt Apr 29, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but you can't fight time 😅 torch 2.7 just came out, they dropped Mac x86 support a year ago.
If it's any relief, Apple stopped selling Intel Macs 2 years ago and will probably stop supporting them in macOS 17 next year.
Maybe AI is more bleeding edge than other uses of computers, changing and developing faster?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this decision should be ultimately up to the project maintainer. /cc @paul-gauthier

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reneleonhardt
reneleonhardt force-pushed the chore/support-py3.13 branch 2 times, most recently from 4989248 to ac1dc82 Compare April 30, 2025 19:30
@reneleonhardt

Copy link
Copy Markdown
Author

@claui How is the review progressing?

@claui

claui commented May 5, 2025

Copy link
Copy Markdown
Contributor

@reneleonhardt Sorry but I’m not actively reviewing this PR. The intent of my comment was to make sure you’re aware of the existing discussion. If GitHub shows me as a reviewer for this PR, then that’s misleading. Sorry about that.

In fact, I’ve filed #3516 (motivated by the Intel Mac requirement) back in March, i.e. before you filed this competing PR. I’m still waiting on @paul-gauthier’s feedback on it.

@reneleonhardt

Copy link
Copy Markdown
Author

Yeah, it's always confusing to me that a contributor isn't allowed to request a review 😞
You're right, it took me a long time to work around all those requirement lockfiles, real dependency management with uv or poetry would be so much easier 👍

@reneleonhardt

Copy link
Copy Markdown
Author

So... AI help for faster contributions isn't wanted and human help for dropping Python 3.9 isn't wanted either, now my work will never get reviewed 👍

@ei-grad

ei-grad commented May 14, 2025

Copy link
Copy Markdown
Contributor

@reneleonhardt Many thanks for this PR! I've been using your PR locally for several weeks, and it worked perfectly both in 3.12/3.13 envs – truly appreciate you sharing this.

It looks like Python 3.13 support might be getting integrated by the maintainer more gradually, in separate parts – perhaps that's why this PR has some conflicts now. That's a challenging situation, and I can imagine it might be disheartening.

Despite that, it really shows that any good contribution you share can make a real difference for someone – your work here has definitely made one for me. Hope this feedback is a positive note!

@reneleonhardt
reneleonhardt force-pushed the chore/support-py3.13 branch from ac1dc82 to 9829c21 Compare May 14, 2025 18:41
@reneleonhardt reneleonhardt changed the title chore(deps): Support Python 3.13 and drop 3.9 chore(deps): Support Python 3.13 May 14, 2025
@reneleonhardt

Copy link
Copy Markdown
Author

Thank you for trying my PR, feels better than being ignored and eventually closed...
I honestly don't know why this hasn't been merged yet, I heard only positive feedback so far.
But at least the maintainers have 5 months to merge this... before Python 3.14 will be released 😉
Which by the way also worked with my PR, at least as far as the pytest coverage is concerned.
If you want you can pull again, I rebased, resolved conflicts and updated a little more.

@Slach

Slach commented Aug 30, 2025

Copy link
Copy Markdown

@reneleonhardt, could you resolve conflicts in this branch?

@reneleonhardt

reneleonhardt commented Aug 30, 2025

Copy link
Copy Markdown
Author

This good old pip-compile style dependency management nobody is using anymore for years is an absolute nightmare.
I could only spend hours again if my work would be constructively reviewed in a timely fashion and then merged if there are no problems.
I have no trust in the maintainers anymore after adding the priority label and then keeping me waiting for 5 months, with 184 open PRs and refusing to allow AI review help which would save valuable contributors time.

Updates are literally time-sensitive, now every dependency constraint in every "requirement" file has to be reevaluated to satisfy all supported Python versions (supposedly 3.10, 3.11, 3.12 and maybe 3.13 if my work would've been merged).

It would be much easier to throw all ancient requirement files away and support the packaging standard (groups in pyproject.toml):
https://packaging.python.org/en/latest/specifications/dependency-groups/
https://peps.python.org/pep-0735/
https://github.com/Aider-AI/aider/blob/main/scripts/pip-compile.sh

@akostadinov

Copy link
Copy Markdown

Seems like this one can already be closed, see #4899 , wtill thank you for your effort, it got me started.

@reneleonhardt

Copy link
Copy Markdown
Author

Yeah, that contribution was reviewed, merged and thanked on the same day.
My PR none of that after one year, feels great that my work isn't appreciated! 👍

@abitrolly

Copy link
Copy Markdown

My PR none of that after one year, feels great that my work isn't appreciated! 👍

I guess in corporate environments agents are just not trained to give credits. Because they assume everybody on a payroll (and that copyright doesn't exist). :D

I appreciate that you've made this PR first. I also started porting to Homebrew's newer Python independently, but some dependencies were not ready at that time, so I've also left with a lot of wasted time and no reward.

The reason why #4899 is merged (as I see it):

  1. all tests are green, including "fork validation PR"
  2. added Python 3.14 too
  3. clear description of what has been done and how it was validated

So.. Rebase, close, prepare/test for 3.16? I dk https://www.python.org/downloads/release/python-3150b2/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.13 support

8 participants