Let 'rich' use code_theme as inline_code_theme - #4193
Merged
Conversation
Collaborator
|
Thanks! |
Contributor
|
I was working on something similar: #4200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The inline code snippets in the reply from AI models are formatted using some default theme. They are somewhat harder to read and are just ugly.

Solution
But if a
inline_code_lexeris not passed torich.markdown.Markdown,inline_code_themeis not being used to style inline code, as evident in the__init__ofrich.markdown.MarkdownContext. But there's no reasonably easy way to determine the programming language of inline code snippets to be able to identify the lexer. This PR's solution is to utilize the lexertextas the value of theinline_code_lexerpassed toMarkdown. In this scenario "rich" usescode_themeas the fallback value forinline_code_theme