fix: handle symlink loops in safe_abs_path()#4838
Merged
Merged
Conversation
Path.resolve() raises RuntimeError on circular symlinks. Catch RuntimeError and OSError, fall back to Path.absolute(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Path.resolve()raisesRuntimeErrorwhen encountering circular symlinks (e.g.v8/v8 -> v8/v8), crashing aider during repo map generation.Path.resolve()call insafe_abs_path()with a try/except forRuntimeErrorandOSError, falling back toPath.absolute()which doesn't follow symlinks.Test plan
test_safe_abs_path_symlink_loopcreates a circular symlink pair and verifiessafe_abs_path()returns an absolute path without raisingpytest tests/basic/test_utils.pypasses