fix: pass --no-verify-ssl to version check, fix SSL_VERIFY, add AIDER_TAGS_CACHE_DIR#5177
Open
superShen0916 wants to merge 2 commits into
Open
fix: pass --no-verify-ssl to version check, fix SSL_VERIFY, add AIDER_TAGS_CACHE_DIR#5177superShen0916 wants to merge 2 commits into
superShen0916 wants to merge 2 commits into
Conversation
The version check (pypi.org query) was always using default SSL verification, even when --no-verify-ssl was passed. This caused startup errors for users behind corporate firewalls with self-signed certificates. Also fixes the SSL_VERIFY environment variable from "" to "false" so LiteLLM correctly recognizes it. Fixes Aider-AI#664 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds support for the AIDER_TAGS_CACHE_DIR environment variable to let users relocate the .aider.tags.cache.v3 directory outside the repo root. This allows a completely uncluttered repo experience when combined with the existing .env support for other aider paths. Fixes Aider-AI#2325 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
shenpeng.sp0916 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes for enterprise/custom-environment users:
1. Version check respects --no-verify-ssl (Fixes #664)
The version check (querying pypi.org) was always using default SSL verification, even when
--no-verify-sslwas passed. This caused startup errors for users behind corporate firewalls with self-signed certificates.2. SSL_VERIFY env var fixed from "" to "false"
LiteLLM checks
SSL_VERIFYas a string. Empty string""may not be recognized as "disable SSL". Changed to"false"for correct LiteLLM behavior.3. Configurable tags cache location (Fixes #2325)
Added support for
AIDER_TAGS_CACHE_DIRenvironment variable. When set, the.aider.tags.cache.v3directory will be created at the specified path instead of the repo root. This allows a completely uncluttered repo when combined with existing.envsupport.Changes
aider/versioncheck.py: Addverify_sslparameter, pass torequests.get()aider/main.py: Passargs.verify_ssltocheck_version(), fixSSL_VERIFYenv varaider/repomap.py: Addget_tags_cache_dir()classmethod andAIDER_TAGS_CACHE_DIRenv var supportTest plan
--no-verify-sslnow propagates to all HTTP requests including version checkAIDER_TAGS_CACHE_DIR=/custom/path aidercreates cache at/custom/path/.aider.tags.cache.v3Risk
Low. All changes are configuration-only and default to existing behavior.
🤖 Generated with Claude Code