Merge pull request #285 from AikidoSec/change-names-for-qa-tests

Change response messages slightly for qa tests

Author: bitterpanda63

agent_api/src/main/java/dev/aikido/agent_api/storage/ServiceConfiguration.java

@@ -97,7 +97,7 @@ public BlockedResult isIpBlocked(String ip) {
         // Check for allowed ip addresses (i.e. only one country is allowed to visit the site)
         // Always allow access from private IP addresses (those include local IP addresses)
         if (!isPrivateIp(ip) && !firewallLists.matchesAllowedIps(ip)) {
-            return new BlockedResult(true, "not in allowlist");
+            return new BlockedResult(true, "not allowed");
         }
 
         // Check for monitored IP addresses

agent_api/src/main/java/dev/aikido/agent_api/vulnerabilities/outbound_blocking/BlockedOutboundException.java

@@ -8,7 +8,7 @@ public BlockedOutboundException(String msg) {
     }
 
     public static BlockedOutboundException get() {
-        String defaultMsg = generateDefaultMessage("an outbound request");
+        String defaultMsg = generateDefaultMessage("an outbound connection");
         return new BlockedOutboundException(defaultMsg);
     }
 }

agent_api/src/test/java/collectors/WebRequestCollectorTest.java

@@ -157,7 +157,7 @@ void testReport_ipNotAllowedUsingLists() {
         contextObject.setIp("4.4.4.4");
         response = WebRequestCollector.report(contextObject);
         assertNotNull(response);
-        assertEquals("Your IP address is blocked. Reason: not in allowlist (Your IP: 4.4.4.4)", response.msg());
+        assertEquals("Your IP address is blocked. Reason: not allowed (Your IP: 4.4.4.4)", response.msg());
         assertEquals(403, response.status());
     }